On Fri, Jul 10, 2009 at 12:08:19PM +0200, Sven Eckelmann wrote:
Hi Folks
This patch fixes a few typos and spelling errors.
You don't specify for which project this patch is
I've emailed Merek a few times in the last day about this and other patches. He is expecting the patch and knows what is applies to. I'm more posting here for review by anybody who is interested. Maybe somebody will require a different dialect of English!
Also, i've been maintainer of an large open source project, eCos. An experience maintainers can very quickly determine what files where are involved.
I am not really sure but I think Marek prefers -p1 unified patches from the trunk... as he has written a script to apply my patches directly from mbox. He seems to interpret the whole message as commit message with the real patch at the end.
My experience from eCos is that the first few patches i get from a new contribute i want to take a very close look at. I generally apply them first with --dry just to make sure there are no surprises, corruption by mail tools, etc and they are against the latest trunk tip, etc. Only after a building up some level of trust with the contributor do i take a more relaxed approach. Since this is my first patch for b.a.t.m.a.n, i don't expect to get all the fine details right and i'm sure Merek will tell me where i'm wrong.
Andrew