From: Marek Lindner lindner_marek@yahoo.de Date: Sat, 26 Nov 2011 22:26:42 +0800
the following 10 patches constitute the first batch I'd like to get the pulled into net-next-2.6/3.3. They're mostly uncritical fixes around the recently introduced tt code, some code refactoring, the kstrto update and the range check fix reported by Thomas Jarosch.
Pulled, thanks.
Some things to look into:
+ if (unlikely(skb_headlen(skb) < + sizeof(struct tt_query_packet) + + tt_len))
This isn't formatted correctly, all the leading edges should line up to the openning parenthesis of the unlikely:
+ if (unlikely(skb_headlen(skb) < + sizeof(struct tt_query_packet) + + tt_len))
Next, there is a lot of linearization done by the stack, but really the thing to do is to make sure that the part you want to look at is linear.
You do this using pskb_may_pull() right before you want to look at some headers. It makes sure that, for the length given, that many bytes are linear at the head of the skb.
Thanks.