Re: [B.A.T.M.A.N.] [PATCHv5 2/2] batman-adv: Add debugfs table for mcast flags

On Sat, Jul 19, 2014 at 06:02:47PM +0800, Marek Lindner wrote:

On Tuesday 15 July 2014 04:38:18 Linus Lüssing wrote:

...

• rcu_read_lock();
  

• hlist_for_each_entry_rcu(orig_node, head, hash_entry) {
  

• 	if (!(orig_node->capa_initialized &
  

• 	      BATADV_ORIG_CAPA_HAS_MCAST))
  

• 		continue;
  

Why not printing '-' in this case as well ?

Had been giving a reason on IRC already, but maybe it's better to write it here again so that the reason doesn't get lost:

The idea was, to only have one entry per batman-adv node. Not per originator. Secondary interface originators aren't considered in the multicast logic anyways, so they might be confusing for the user when doing manual checking and counting.

In other words, '-' is supposed to mean that this is an outdated node not supporting multicast optimizations and not having the according TVLV and that people should consider upgrading it.

Cheers, Linus