On Tue, Jul 14, 2009 at 03:09:26PM +0200, Andrew Lunn wrote: What are peoples opinion about this? Should i spend a little time cleaning up all the files? Some code needs refactoring a little, to reducing the nesting, creating more helper functions, but mostly its white space changes. However such changes can cause pain when trying to merge in other work people who diff's are against before the cleanup. Does anybody have any major patches?
I am not a batman-adv developer but I am definitely pro cleanup. There aren't many known people which write code against the current version who wants to merge with trunk. And I think it is better to remove the clutter now instead of waiting until more "chaos" was created. You should check out the scripts inside Andrew Morton's kernel[1,2]. I checked them some time ago and they were far better then the ones inside the vanilla kernel. I think most of that changes are already merged, but I don't know in which version.
[1] http://userweb.kernel.org/~akpm/mmotm/ [2] git://git.zen-sources.org/zen/mmotm.git