Hi,
On Saturday, 14 May 2022 11:51:38 CEST Sven Eckelmann wrote:
This version cannot be applied on top of the current master. I have attached the diff for the things which (afaik) need to be changed when you rebase the patch.
I have also attached the change to support the reporting of the source mac for the changed dataset.
I like the epoll change (to avoid unnecessary clutter) and also the source MAC reporting. For debugging purposes it might be useful to know where the change came from.
Thanks for preparing the rebase & code change patches. Wouldn't you say that EPOLL_CTL_DEL somewhere near unix_sock_event_listener_free() could be helpful?
Something like: -static void unix_sock_event_listener_free(struct event_listener *listener) +static void unix_sock_event_listener_free(struct globals *globals, + struct event_listener *listener) { list_del(&listener->list); + epoll_ctl(globals->epollfd, EPOLL_CTL_DEL, listener->fd, NULL); close(listener->fd); free(listener); }
Kind regards, Marek Lindner