Re: [B.A.T.M.A.N.] [PATCH maint 2/3] batman-adv: fix header size check in batadv_dbg_arp()

On 03/16/2018 12:31 PM, Sven Eckelmann wrote:

On Freitag, 16. März 2018 11:29:10 CET Matthias Schiffer wrote:

...

Checking for 0 is insufficient: when an SKB without a batadv header, but with a VLAN header is received, hdr_size will be 4, making the following code interpret the Ethernet header as a batadv header.

Signed-off-by: Matthias Schiffer mschiffer@universe-factory.net

Fixes: 0591c25abca9 ("batman-adv: Distributed ARP Table - add ARP parsing functions")

I think this one would be more appropriate:

Fixes: 3e26722bc9f2 ("batman-adv: make the Distributed ARP Table vlan aware")

Kind regards, Sven