On Tuesday 24 May 2016 14:49:31 Simon Wunderlich wrote:
Hi,
On Tuesday 24 May 2016 18:00:18 Antonio Quartulli wrote:
On Tue, May 24, 2016 at 12:31:17AM +0200, Linus Lüssing wrote:
Fixes: 29b9256e6631 ("batman-adv: consider outgoing interface in OGM sending") Signed-off-by: Linus Lüssing linus.luessing@c0d3.blue
Note sure whether the "forw_packet->if_incoming != primary_if" check vanished on purpose or by accident in the mentioned commit. Or whether it got substituted by some other check. Therefore sending the patch as RFC.
I think Simon can better comment on this, but my understanding is that such check has been moved to batadv_iv_ogm_schedule(), thus primary_if is useless in this function.
Simon, comments ?
Yes, the check has been moved. I would agree that the check is redundant now. Please resend without RFC and add my Acked-by :)
What I meant: the local variable is redundant now. I should start reading what I type up ... ;) Sorry!
Simon