Re: [B.A.T.M.A.N.] PATCH fragmentation of unicast packets

Marek has published some patches for the debugging infrastructure. Please adjust your patch for that.

Andreas Langer wrote:

• if (frag_enabled_tmp < 0) {

• if (buff[count - 1] == '\n')
  

• 	buff[count - 1] = '\0';
  

• printk(KERN_ERR "batman-adv:Invalid parameter for 'frag' setting on 
  

mesh

%s received: %s\n",

•        net_dev->name, buff);
  

Please change the printk to a bat_err (remove the batman-adv: and the information on which mesh it happened).

• if (atomic_read(&bat_priv->frag_enabled) == frag_enabled_tmp)

• return count;
  

• printk(KERN_INFO "batman-adv:Changing frag from: %s to: %s on mesh:

%s\n", + atomic_read(&bat_priv->frag_enabled) == 1 ?

•       "enabled" : "disabled",
  

•       frag_enabled_tmp == 1 ? "enabled" : "disabled",
  

•       net_dev->name);
  

That printk to a bat_err (remove the batman-adv: and the information on which mesh it happened).

atomic_set(&batman_if->seqno, 1);

• atomic_set(&batman_if->frag_seqno, 1); printk(KERN_INFO "batman-adv:Adding interface: %s\n", batman_if->dev);

Please rebase your patch on top of the current trunk. Otherwise we have an merge failure here.

• 	if (!orig_node) {
  

• 		printk(KERN_WARNING
  

• 			"frag: couldn't find orig node\n");
  

• 		return NET_RX_DROP;
  

• 	}
  

Please change the printk to pr_warning.

Best regards, Sven