On Sunday, 1 May 2022 09:54:26 CEST Sven Eckelmann wrote:
printf("\n"); printf("server mode options:\n"); printf(" -i, --interface specify the interface
(or
comma separated list of interfaces) to listen on\n");> @@ -164,6 +165,7 @@ static struct globals *alfred_init(int argc, char *argv[])> {"change-interface", required_argument, NULL,
'I'},
{"change-bat-iface", required_argument, NULL,
'B'},
{"server-status", required_argument, NULL, 'S'},
{"event-monitor", required_argument, NULL, 'E'},Why does it require an argument but the usage doesn't describe the argument?
Copy & paste error from server-status which does not require an argument either. Might need to fix in a separate patch.
I am wondering now if it could be interesting for the listener whether the data is from us or some remote (for example via the source mac). Does anyone else have an opinion about that?
Currently, no use-case comes to my mind.
+static void unix_sock_event_listener_free(struct event_listener *listener) +{
- list_del_init(&listener->list);
- close(listener->fd);
- free(listener);
list_del_init has no benefit (only downsides) when you free the memory anyway at the end of the function
What are those downsides you are referring to ?
Thanks for the review!
Kind regards, Marek Lindner