Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: fix skb leak in batadv_dat_snoop_incoming_arp_reply()

On Thursday, January 24, 2013 05:14:03 Antonio Quartulli wrote:

On Thu, Jan 24, 2013 at 05:11:37AM +0800, Antonio Quartulli wrote:

...

Hi Matthias,

very good catch!

On Wed, Jan 23, 2013 at 06:11:53PM +0100, Matthias Schiffer wrote:

...

The callers of batadv_dat_snoop_incoming_arp_reply() assume the skb has been freed when it returns true; fix this by calling kfree_skb before returning as it is done in batadv_dat_snoop_incoming_arp_request().

Signed-off-by: Matthias Schiffer mschiffer@universe-factory.net

Acked-by: Antonio Quartulli ordex@autistici.org

I forgot to say that this fix should be merged into maint, so that we can send it to net.

Applied in revision 977d8c6.

Thanks, Marek