Re: [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: improved gateway tq-based selection

On gio, mag 05, 2011 at 03:46:49 +0200, Andrew Lunn wrote:

On Thu, May 05, 2011 at 09:13:09AM +0200, Antonio Quartulli wrote:

...

• /* If old_gw != NULL then this packet is unicast.

• * So, at this point it can only be a renewal packet (because it is the
  

• * only dhcp client message sent as unicast) and we have to decide
  

• * whether to drop it or not */
  

What about the release message? Is that not also unicast?

You are right (dhcpdecline is unicast too). I have to inspect the dhcp header and look at the message type option.

...

• if (old_gw && curr_gw->orig_node != old_gw) {

• /* If the dhcp packet has been sent to a different gw, we have
  

•  * to evaluate whether the old gw is still enough reliable */
  

still reliable enough.

Thanks!