Re: [B.A.T.M.A.N.] [PATCH v2 1/2] batman-adv: Annotate deleting functions with external lock via lockdep

On Sunday, June 21, 2015 14:45:14 Sven Eckelmann wrote:

Functions which use (h)list_del* are requiring correct locking when they operate on global lists. Most of the time the search in the list and the delete are done in the same function. All other cases should have it visible that they require a special lock to avoid race conditions.

Lockdep asserts can be used to check these problem during runtime when the lockdep functionality is enabled.

Signed-off-by: Sven Eckelmann sven@narfation.org

v2:

• no change

net/batman-adv/main.c | 11 ++++++++--- net/batman-adv/multicast.c | 13 +++++++++++-- net/batman-adv/network-coding.c | 4 ++++ net/batman-adv/translation-table.c | 2 ++ 4 files changed, 25 insertions(+), 5 deletions(-)

Applied in revision 5b95c42.

Thanks, Marek