On Sun, Apr 10, 2016 at 02:07:48PM +0200, Linus Lüssing wrote:
On Thu, Apr 07, 2016 at 03:03:11PM +0200, Simon Wunderlich wrote:
To avoid compatibility issues with older nodes not yet implementing this report handling, we need to force them to flood reports: We do this by bumping the multicast TVLV version to 2, effectively disabling their multicast optimization.
It looks like you register two containers, one with version 1 and version 2, both with the same content. Do we really need to have both containers? Wouldn't it be sufficient to register only version 2 and leave version 1 out?
The idea is to avoid unexpected regressions:
[...]
The registeration of two containers is probably a minor improvement. Haven't heard of any actual setups which would need it yet. On the other hand it's not that much extra code, so it felt like a good idea to add it for some extra compatibility courtesy.
My intention would be to have it just as a transitional mechanism, too. Removing it in 2-4 years maybe.
Regards, Linus