On Mon, Nov 19, 2012 at 03:08:15PM -0500, Sasha Levin wrote:
The code that works with routing_algo assumes that the string passed is non empty, this assumption is wrong:
sh-4.2# echo -ne '\0' > /sys/module/batman_adv/parameters/routing_algo [ 34.531340] BUG: unable to handle kernel paging request at ffff880015142fff
[CUT]
[ 34.550025] ---[ end trace 6c53b662c574774b ]---
Signed-off-by: Sasha Levin sasha.levin@oracle.com
Hello Sasha,
thank you very much for fixing this bug!
However, any patch sent against the B.A.T.M.A.N.-Advanced code should have a subject starting with "batman-adv:".
Other than that I think this kind of patch doesn't really need to report the entire kernel message: a more exhaustive commit message is enough (e.g. use function names). I personally needed to read the patch before understanding what you were trying to explain in the message.
Then, we usually pick this patches up in our repo and then we send them as batch to the networking tree via pull request, therefore you can also skip the netdev ml when sending the fixes.
Thank you very much!
Regards,