Re: [B.A.T.M.A.N.] [PATCHv5 1/2] batman-adv: use eth_hdr() instead of skb->data in interface_tx path

On 19/01/14 00:16, Linus Lüssing wrote:

Our .ndo_start_xmit handler (batadv_interface_tx()) can rely on having the skb ether header pointer set correctly since the following commit present in kernels >= 3.9:

"net: reset mac header in dev_start_xmit()" (6d1ccff627)

Therefore we can safely use eth_hdr() instead of skb->data now, which spares us some ugly type casts.

Signed-off-by: Linus Lüssing linus.luessing@web.de

Linus,

in interface_tx() we also have an assignment for vlan_hdr getting the value of skb->data as well.

Would you mind switching it to vlan_eth_hdr() ?

Maybe you can have a quick look whether there are other occurrences to change within interface_tx()?

Cheers,