Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Avoid relation operator comparison with bool

On 20/02/18 19:08, Sven Eckelmann wrote:

commit 34b3c3850e7d ("batman-adv: Distributed ARP Table - create DHT helper functions") introduced a return check of batadv_compare_eth which uses a boolean return value since commit 16af73458aca ("batman-adv: main, batadv_compare_eth return bool"). A relational (<, >, <= or >=) operator is not the right one for such a check.

Reported-by: David Binderman dcb314@hotmail.com Signed-off-by: Sven Eckelmann sven@narfation.org

---

Cc: David Binderman dcb314@hotmail.com Cc: Antonio Quartulli a@unstable.cc Cc: Markus Pargmann mpa@pengutronix.de

---

Acked-by: Antonio Quartulli a@unstable.cc