Re: [B.A.T.M.A.N.] [PATCH 5/6] batman-adv: restructure rebroadcast counter into forw_packet API

On Sonntag, 29. Januar 2017 14:57:42 CET Linus Lüssing wrote:

This patch refactors the num_packets counter of a forw_packet in the following three ways:

1. Removed dual-use of forw_packet::num_packets: -> now for aggregation purposes only
2. Using forw_packet::skb::cb::num_bcasts instead: -> for easier access in aggregation code later
3. make access to num_bcasts private to batadv_forw_packet_*()

I like this change but have some questions (but no time to check it). Is cb initialized when a new skbuff is allocated? And what about the initialization for packets we get via batadv_interface_tx? At least batman-adv is only setting it to zero when we receive a new packet from an hardif (batadv_batman_skb_recv).

Kind regards, Sven