On Monday 20 June 2016 19:58:03 Linus Lüssing wrote: [...]
@@ -478,20 +546,16 @@ int batadv_add_bcast_packet_to_list(struct batadv_priv *bat_priv,
[...]
Regarding these two goto's, usually using a "return" directly instead of a "goto out" is better, I agree. For these two cases I think I would prefer keeping it that way, because it's not a simple return but a return of a macro value. Having NETDEV_TX_OK and NETDEV_TX_BUSY each only once in a function makes it easier to spot the good or bad cases, I think?
Or maybe I could rename "out" and "packet_free" to "err" and "err_packet_free" to make the error cases even more visible?
Hm, not sure if this is really required but I honestly like the names "err" and "err_packet_free" right now :)
Kind regards, Sven