23 Jun
2010
23 Jun
'10
4 p.m.
On Wednesday 23 June 2010 17:17:27 Sven Eckelmann wrote:
Can you please change that (at least the 'null' function) from a define to an static inline function? Otherwise there are a lot of "unused" warning when compiling without debug support.
static inline void bat_dbg(char type __attribute__((unused)), struct bat_priv *bat_priv __attribute__((unused)), char *fmt __attribute__((unused)), ...) { }
Sure, will do.
To you suggestion to add more information from kernel log to the debug log
- it seems to be interesting, but we must ensure that those information
are specific to a mesh device. I will sent a patch which modifies all printks later. Maybe we could discuss where it would be a benefit and where it is not needed (~54 printks are for discussion).
Yes, sounds good.
Regards, Marek