Hi Simon,
On 17/07/2008, at 8:00 PM, Simon Wunderlich wrote:
Hey Scott,
thank you for the patch, it looks good to me so i applied it. Having a compat.h is a good idea, maybe we should use it even more to get rid of some ugly #ifdef's. :) I've tested your patch against various kernels, it seems to work until 2.6.20, but breaks for 2.6.19.
Great, thanks. The idea of a compat.h for those macros is blatantly stolen from madwifi, which I'm a casual contributor to :) If I get some more spare time I'll look at fixes for earlier kernels, but I needed to target 2.6.21 with a project I'm working on, hence the patch :)
We welcome any kind of patches, so don't hesitate to submit. We can integrate them directly (like your patch) or offer them on our homepage (like the quagga patches [1]).
I'll keep that in mind - hopefully as we start to play with the module some more I'll be able contribute further.
Cheers,
-- Scott Raynel WAND Network Research Group Department of Computer Science University of Waikato New Zealand