Re: [B.A.T.M.A.N.] [PATCHv3 maint] batman-adv: protect tt_local_entry from concurrent delete events

On Friday, June 19, 2015 10:45:41 Antonio Quartulli wrote:

On 19/06/15 09:18, Marek Lindner wrote:

...

The tt_local_entry deletion performed in batadv_tt_local_remove() was neither protecting against simultaneous deletes nor checking whether the element was still part of the list before calling hlist_del_rcu().

Replacing the hlist_del_rcu() call with batadv_hash_remove() provides adequate protection via hash spinlocks as well as an is-element-still-in-hash check to avoid 'blind' hash removal.

Fixes: 2443ba3 ("batman-adv: roaming handling mechanism redesign")

Reported-by: alfonsname@web.de Signed-off-by: Marek Lindner mareklindner@neomailbox.ch

Acked-by: Antonio Quartulli antonio@meshcoding.com

Applied in revision af912d7.

Regards, Marek