Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: drop QinQ claim frames in bridge loop avoidance

On Monday 23 June 2014 15:55:36 Simon Wunderlich wrote:

From: Simon Wunderlich simon@open-mesh.com

Since bridge loop avoidance only supports untagged or simple 802.1q tagged VLAN claim frames, claim frames with stacked VLAN headers (QinQ) should be detected and dropped. Transporting the over the mesh may cause problems on the receivers, or create bogus entries in the local tt tables.

Reported-by: Antonio Quartulli antonio@open-mesh.com Signed-off-by: Simon Wunderlich simon@open-mesh.com

---

Changes to PATCHv2 (thanks Marek):

• move check into bla_process_claim() to avoid code duplication

Changes to PATCHv1 (thanks Antonio):

• add short description, fix capitalization for return
• move drop debug message to batadv_bla_process_claim()

---

bridge_loop_avoidance.c | 44 ++++++++++++++++++++++++++++++++++---------- 1 file changed, 34 insertions(+), 10 deletions(-)

Applied in revision 8cd753e.

Thanks, Marek