On Tuesday 18 September 2012 16:41:58 Def wrote:
Into function interface_set_mac_addr, the function tt_local_add was invoked before updating dev->dev_addr. The new MAC addresse was not tagged as NoPurge.
Please don't add extra whitespaces before your commit message.
Your Signed-off-by: is missing.
[...]
- memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
Please don't add trailing whitespaces.
I have no idea whether this works... *looks at Antonio*. But thanks for bringing this up in the issue tracker and sending this first version of the patch.
The problems mentioned here can be found using checkpatch/cppcheck/sparse/smatch [1]. We need to drop this patch due to these problems because the next authorities (David S. Miller/Linus Torvalds/...) would not be happy when we forward them this version of the patch.
Kind regards, Sven
[1] http://www.open-mesh.org/projects/open-mesh/wiki/Contribute#Submitting-patch...