17 May
2011
17 May
'11
7:09 p.m.
Nack
There are two many small things that need to be changed. I didn't to a complete review, but at least the primary_if dereference is unacceptable.
From IRC:
<ecsv_> could you do me the favour and go through my cleanup patches and also fix your code... it is too much to send every problem to the list <ecsv_> and the kfree_rcu patches will be merged soon in linux mainline... so please prepare your patches for that <ecsv_> and why is there still an align in batman_packet - this doesn't make any sense <ecsv_> and we already have functionality to do the before-after check of the ttvn <ecsv_> and you try to dereference primary_if (without using primary_if_get_selected) directly... this is not allowed
Kind regards, Sven