18 May
2016
18 May
'16
2:16 a.m.
On Tue, May 17, 2016 at 07:32:32PM +0200, Sven Eckelmann wrote:
[...]
@@ -58,6 +59,7 @@ static void batadv_socket_add_packet(struct batadv_socket_client *socket_client, void batadv_socket_init(void) { memset(batadv_socket_client_hash, 0, sizeof(batadv_socket_client_hash));
- batadv_tp_meter_init();
Sven, one very last question (sorry for not spotting this earlier): if we don't handle the TP meter with the icmp_socket anymore, why do we tight the TP initialization to the socket initialization ?
Is there any reason to have it here ? Or we should move the batadv_tp_meter_init() call to somewhere else ?
[...]
+/**
- batadv_netlink_tpmeter_notify - send tp_meter result via netlink to client
- @bat_priv: the bat priv with all the soft interface information
- @dst: destination of tp_meter session
- @result: reason for tp meter session stop
- @test_time: total time ot the tp_meter session
- @total_bytes: bytes acked to the receiver
- @cookie: cookie of tp_meter session
- Return: 0 on success, <0 on error
you forgot the space between < and 0 ;P but if the rest is ok, I am sure Marek could add it :)
The rest looks good. Thanks !
--
Antonio Quartulli