Re: [B.A.T.M.A.N.] [batman-adv] Cleanup aggregation.[ch]

On Saturday 18 July 2009 22:32:50 Andrew Lunn wrote:

Make aggregation.[ch] clean with respect to the 2.6.29 checkpatch script.

Signed-off-by: Andrew Lunn andrew.lunn@ascom.ch

I applied your patch. I noticed you created a function for the calculcation of the hna length. It does not really do much. Would it make sense to transform it into a macro ? While reviewing the code I saw multiple incarnations of the variable own_packet. Sometimes it is char, uint8_t or int. Not sure what effect it might have but I think it would be better to unify that ?!

Regards, Marek