Re: [PATCH v2 1/2] batman-adv: mcast: detect, distribute and maintain multicast router presence

On Tuesday, 7 May 2019 06:20:03 CEST Linus Lüssing wrote:

+static u8 batadv_mcast_mla_rtr_flags_softif_get(struct batadv_priv *bat_priv,

•                                           struct net_device *bridge)
  

+{

•   struct net_device *dev = bridge ? bridge : bat_priv->soft_iface;
  

•   u8 flags = BATADV_NO_FLAGS;
  

•   struct inet6_dev *in6_dev;
  

•   struct in_device *in_dev;
  

•   rcu_read_lock();
  

•   in_dev = __in_dev_get_rcu(dev);
  

•   if (in_dev && IN_DEV_MFORWARD(in_dev))
  

•           flags |= BATADV_MCAST_WANT_ALL_RTR4;
  

•   in6_dev = __in6_dev_get(dev);
  

•   if (in6_dev && in6_dev->cnf.mc_forwarding)
  

•           flags |= BATADV_MCAST_WANT_ALL_RTR6;
  

•   rcu_read_unlock();
  

•   return flags;
  

+}

Fails to build on Linux 5.1 with:

/home/sven/tmp/qemu-batman/batman-adv/net/batman-adv/multicast.c: In function 'batadv_mcast_mla_rtr_flags_softif_get': /home/sven/tmp/qemu-batman/batman-adv/net/batman-adv/multicast.c:130:30: error: 'struct ipv6_devconf' has no member named 'mc_forwarding'; did you mean 'forwarding'? if (in6_dev && in6_dev->cnf.mc_forwarding) ^~~~~~~~~~~~~ forwarding

See https://git.open-mesh.org/build_test.git/blob/HEAD:/generate_linux_headers.s... for the configuration.

Kind regards, Sven