Re: [B.A.T.M.A.N.] [PATCH 5/5] batctl: Only parse big enough TVLV TTv1

On Wednesday 12 November 2014 18:58:29 Sven Eckelmann wrote:

A TTv1 has a constant header part and two variable parts. One is the defined by the number of VLANs and the rest are the changes. The TVLV can only be parsed when there is enough room for the constant header. Also the number of VLANs must be validated. Otherwise the TVLV parser can read invalid data outside of the buffer.

This regression was introduced by 4c39fb823b86036df40187f8bd342fe5398c28ef ("batctl: tcpdump - parse TVLV containers").

Signed-off-by: Sven Eckelmann sven@narfation.org

tcpdump.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)

Applied in revision 5fda4d5.

Thanks, Marek