Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Update pointer to ethhdr after skb_copy

Marek Lindner wrote:

...

@@ -1106,6 +1110,7 @@ int recv_unicast_packet(struct sk_buff *skb)

if (!skb)

return NET_RX_DROP; unicast_packet = (struct unicast_packet *) skb->data;

• ethhdr = (struct ethhdr *)skb_mac_header(skb);
  
  

  kfree_skb(skb_old);

  }

I was about to commit your patch when I fell over these last 2 changes. I can't see why we need them. What did I miss ?

They are not really needed, but just wanted to have them in for later usage and to have it more consistent (otherwise copy and paste easily leads to funny effects for some people which cannot be reproduced by the maintainers). So it could be removed in recv_icmp_packet and recv_unicast_packet if you prefer it.

Best regards, Sven