On Sun, Nov 24, 2024 at 11:00:40AM +0100, Sven Eckelmann wrote:
On Friday, 22 November 2024 16:52:52 CET Remi Pommarel wrote:
del_op_entry = entry->change.flags & BATADV_TT_CLIENT_DEL;This line must not be dropped. Just checked my PoC change and it seems like I already dropped it. I thought I've spotted and fixed this before. But most likely, I've just changed it in the editor and then forgot to copy it back to the mail client.
Outch, sorry for not having noticed that. I am a bit surprised that gcc does not complain.
It is also called "Co-Developed-by: " and needs a SoB directly after that (which I didn't give at that specific point - but now did in batadv/net-next).
Actually according to checkpatch the preferred tag seems to be "Co-developed-by", which was still not what I used. Also I have mixed feeling about this tag, I have been asked before to add the Co-developped-by tag but I don't really feel confortable giving Signed-off-by in other people name....
Don't know if you noticed, but I also messed up indentation at line 505, my bad.
I have now changed this directly the batadv/net-next branch. But in case there needs to be a v6, please also change this locally on your end.
We will still wait for Antonio before I consider it really as accepted (and then try to send it to the netdev maintainers).
Thanks.
Regards,