Re: [B.A.T.M.A.N.] slowpath warning

On Mon, Mar 01, 2010 at 05:57:06PM +0100, Simon Wunderlich wrote:

Hey Andrew,

all list-adds and list-removes do a kref_get or kref_put respectively, but that probably was not very clear. As soon as a refence is created (by linking into the hash or a list), we should also kref_get() it.

Please find attached a new version of this patch with separate send_list_add/remove functions which include the put/get functions. I've also added the kref_put/get call to the send_list loop again. It should look more balanced now. Tested in my 9 qemu setup again, no memory leaks or crashes but i only did a very quick test (15 minutes)

Hi Simon

This looks better. Did it survive longer testing?

Andrew