Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: Fix symmetry check / route flapping in multi interface setups

23 Sep 2012


      On Tuesday, September 18, 2012 09:01:08 Linus Lüssing wrote:
...
@@ -743,7 +744,8 @@ batadv_iv_ogm_orig_update(struct batadv_priv *bat_priv,
        if (router && (neigh_node->tq_avg == router->tq_avg)) {
                orig_node_tmp = router->orig_node;
                spin_lock_bh(&orig_node_tmp->ogm_cnt_lock);

          sum_orig =



orig_node_tmp->bcast_own_sum[if_incoming->if_num]; +               if_num
= router->if_incoming->if_num;

          sum_orig = orig_node_tmp->bcast_own_sum[if_num];
          spin_unlock_bh(&orig_node_tmp->ogm_cnt_lock);

          orig_node_tmp = neigh_node->orig_node;



Good catch! May I suggest another modifcation to make this section easier to 
understand ? It won't change any behavior it just makes it easier to see where 
if_num is coming from.
Cheers,
Marek

    