On Tuesday, December 25, 2012 07:18:37 Pau Koning wrote:
What decision? I only see something about Patch 6 and Patch 7: Antonio Quartulli doesn't want rtnetlink support in batman-adv. I don't see any other statement about the rest of the patchset.
Quoting Antonio:
Anyway, I discussed about this together with the others and it seems that a proper solution now is to wait before merging this patchset and fix the current sysfs/rtnl_lock problem first. What do you think?
Adding a new API without fixing the current one doesn't sound like a good move. <<<
What isn't clear ?
AFAIK patch 6 and 7 are the "new" rtnetlink API. The rest can be categorized as fixes for bugs and for the wrong way to implementation things.
After looking at the patches again, I'd say only patch1 & patch2 could be categorized as "fixes" while the remaining patches are preparation patches for the netlink stuff which is added in the last step. Whether patch1 & patch2 actually fix problems batman-adv already has today or whether they are necessary once you use netlink is unclear to me. If they are unrelated to this patchset they'd be sent separately, wouldn't they ?
Cheers, Marek