There are some remaining remarks, but most of them are wrong (seems to be a icc bug or missing feature for #810er remarks). Thing which should be checked are get_rp_filter, get_send_redirects, get_forwarding, set_rp_filter, set_send_redirects and set_forwarding. These functions use int32_t to represent the state during set or get, but batmand stores the result of all get functions as int8_t in batman.c:batman and struct batman_if....
Best regards, Sven