On Mittwoch, 2. November 2016 18:14:43 CET Sven Eckelmann wrote:
The commit bac7733d06fa ("batman-adv: fix splat on disabling an interface") fixed a warning but at the same time broke the rtnl function add_slave for devices which were temporarily removed.
batadv_softif_slave_add requires soft_iface of and hard_iface to be NULL before it is allowed to be enslaved. But this resetting of soft_iface to NULL in batadv_hardif_disable_interface was removed with the aforementioned commit.
Reported-by: Julian Labus julian@freifunk-rtk.de Signed-off-by: Sven Eckelmann sven@narfation.org Cc: Linus Lüssing linus.luessing@c0d3.blue Acked-by: Linus Lüssing linus.luessing@c0d3.blue
This is a simple revert. Linus, feel free to propose a patch to remove the "|| hard_iface->soft_iface" when you think it is safe and you've tested that it works
Bug report for it can be found at https://www.open-mesh.org/issues/307
net/batman-adv/hard-interface.c | 1 + 1 file changed, 1 insertion(+)
Applied in 89d0e31c2cc790743ee373b717c05ca85caf8384 [1].
Kind regards, Sven
[1] https://git.open-mesh.org/batman-adv.git/commit/89d0e31c2cc790743ee373b717c0...