Re: [B.A.T.M.A.N.] [PATCH 03/16] batman-adv: add bat_orig_print API function

On Wed, 2013-10-23 at 18:04 +0200, Antonio Quartulli wrote:

Each routing protocol has its own metric and private variables, therefore it is useful to introduce a new API for originator information printing.

This API needs to be implemented by each protocol in order to provide its specific originator table output.

[]

+static void batadv_iv_ogm_orig_print(struct batadv_priv *bat_priv,

• 		     struct seq_file *seq)
  

[]

• seq_printf(seq, " %-15s %s (%s/%i) %17s [%10s]: %20s ...\n",

•    "Originator", "last-seen", "#", BATADV_TQ_MAX_VALUE,
  

•    "Nexthop", "outgoingIF", "Potential nexthops");
  

This header printf really doesn't add much with the formatting sizes. It's pretty obscure why some of these are sized and others not sized. For instance: %-15s doesn't refer to a mac address size. Perhaps it'd be better to just emit the fixed string just using BATADV_TO_MAX_VALUE. It'd also be easier to find via grep.