Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: softif lan loop avoidance

On Tuesday 28 September 2010 23:23:03 Sven Eckelmann wrote:

Do you want to change the other _hold and _put functions to make it consistent in batman-adv regarding the NULL pointer checks?

Yes, I will send patches for that.

You must protect the whole loop and not only the hlist_del_rcu with the bat_priv->softif_neigh_lock, And it must be with spin_lock_irqsave because you use it in context were irq is disabled and in some with enabled irq contexts... or am I wrong?

No, you are right - I will add the irq locks.

Can you mark that function as static?

Done.

Thanks for your review, Marek