Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Less function calls in batadv_is_ap_isolated() after error detection

On Mon, Mar 14, 2016 at 03:25:02PM -0400, David Miller wrote:

From: SF Markus Elfring elfring@users.sourceforge.net Date: Fri, 11 Mar 2016 13:40:56 +0100

...

From: Markus Elfring elfring@users.sourceforge.net Date: Fri, 11 Mar 2016 13:10:20 +0100

The variables "tt_local_entry" and "tt_global_entry" were eventually checked again despite of a corresponding null pointer test before.

• Avoid this double check by reordering a function call sequence and the better selection of jump targets.

• Omit the initialisation for these variables at the beginning then.

Signed-off-by: Markus Elfring elfring@users.sourceforge.net

I am assuming Antonio will take this in via his tree.

Yeah, it will go through our tree. Still under review right now.

Cheers,