On Montag, 1. August 2016 22:57:16 CEST Linus Lüssing wrote:
On Fri, Jul 22, 2016 at 12:19:54AM +0200, Sven Eckelmann wrote:
On Donnerstag, 21. Juli 2016 23:59:30 CEST Sven Eckelmann wrote:
On Donnerstag, 21. Juli 2016 23:38:32 CEST Linus Lüssing wrote:
struct hlist_head mla_list;
struct hlist_head mla_list; /* protected by mcast.work */Protected by a workqueue item? How?
Looks like you wanted to say here that it is only modified inside the worker queue (via the mcast.work delayed workqueue item) - unless it is not done this way like in batadv_mcast_free after cancel_delayed_work_sync.
Exactly :). I tried to "summarize" that a little to make it fit as an inline comment ;). (although there are some further kerneldoc remarks on the functions using it)
Is it ok now or do you think I should add something like your explanation somewhere else?
I personally don't like the statement "protected by mcast.work". Maybe you can add something like "see ...." to reference the functions/kernel-doc describing why it "protects" it.
Kind regards, Sven