Re: [B.A.T.M.A.N.] [PATCH 2/2] batctl: tcpdump - print subtype for UNICAST4ADDR packets

On Tue, Apr 02, 2013 at 04:41:31PM +0800, Marek Lindner wrote:

On Monday, April 01, 2013 04:03:18 Antonio Quartulli wrote:

...

Signed-off-by: Antonio Quartulli ordex@autistici.org

tcpdump.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tcpdump.c b/tcpdump.c index 39239dd..bf4edd4 100644 --- a/tcpdump.c +++ b/tcpdump.c @@ -562,7 +562,8 @@ static void dump_batman_4addr(unsigned char *packet_buff, ssize_t buff_len, int

printf("%s: 4ADDR, subtype %d, ttvn %d, ttl %hhu, ", get_name_by_macaddr((struct ether_addr *)unicast_4addr_packet->u.dest, read_opt),

•       unicast_4addr_packet->u.ttvn, unicast_4addr_packet->u.header.ttl); 
  

•       unicast_4addr_packet->subtype, unicast_4addr_packet->u.ttvn, 
  

•       unicast_4addr_packet->u.header.ttl);
  
  

You added the subtype printf format string with the previous patch already. You might want to fix this.

ops, thanks! I did not realised that when I created the two patches.

Thanks a lot. Will send v2.

Cheers,