On Monday, May 09, 2016 18:45:33 Antonio Quartulli wrote:
Without my patch: root@OpenWrt:/# cat /sys/class/net/eth1/batman_adv/elp_interval 500 root@OpenWrt:/# echo 700 > /sys/class/net/eth1/batman_adv/elp_interval [51835.004638] batman_adv: eth1: elp_interval: Changing from: 500 to: 700 root@OpenWrt:/# ifconfig eth1 down && ifconfig eth1 up root@OpenWrt:/# cat /sys/class/net/eth1/batman_adv/elp_interval 500
Performed the same, but I cannot reproduce. I tested:
- origin/maint: 9685688ae7dd85804aec2f6ce760611551fe9635
- origin/master: 7608af0adebb29dc25bd8aa489ad8a2d0e4a6317
Are you sure you are not testing this with other patches applied ?
root@OpenWrt:/# batctl -v batctl f29682c [batman-adv: 7608af0] root@OpenWrt:/# cat /sys/class/net/eth1/batman_adv/elp_interval 500 root@OpenWrt:/# echo 700 > /sys/class/net/eth1/batman_adv/elp_interval [ 62.176281] batman_adv: eth1: elp_interval: Changing from: 500 to: 700 root@OpenWrt:/# ifconfig eth1 down && ifconfig eth1 up root@OpenWrt:/# cat /sys/class/net/eth1/batman_adv/elp_interval 500
Am I right assuming you're not testing with Openwrt ? I suspect it is netifd that removes the interface from batX entirely on ifconfig down. That might not be the same on your system. I can reword the commit message to not mention interface down if you like.
Cheers, Marek