On Saturday, 1 February 2025 05:31:27 GMT+1 Linus Lüssing wrote:
v5:
- rebased to current main branch: -> PATCH 3/3 needed to readd the include for soft-interface.h for batadv_softif_get_bridge() since commit "50eddf397ac3 batman-adv: netlink: reduce duplicate code by returning interfaces"
I see also following reports:
ecsv/pu: headers ----------------
diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index 051e7fce..30f65708 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -23,6 +23,7 @@ #include <linux/kref.h> #include <linux/list.h> #include <linux/lockdep.h> +#include <linux/net.h> #include <linux/netdevice.h> #include <linux/netlink.h> #include <linux/percpu.h>
ecsv/pu: kerneldoc ./net/batman-adv/soft-interface.c ----------------------------------------------------
./net/batman-adv/soft-interface.c:566: warning: Function parameter or struct member 'own' not described in 'batadv_softif_create_vlan' ./net/batman-adv/soft-interface.c:626: warning: Function parameter or struct member 'own' not described in 'batadv_softif_vlan_get_or_create'
ecsv/pu: unused_symbols -----------------------
cfg:
* unused_symbols cfg: BLA=n DAT=n DEBUG=n TRACING=n NC=n MCAST=n BATMAN_V=y * unused_symbols cfg: BLA=n DAT=n DEBUG=n TRACING=n NC=y MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=n DAT=n DEBUG=n TRACING=y NC=n MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=n DAT=n DEBUG=y TRACING=n NC=n MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=n DAT=n DEBUG=y TRACING=n NC=n MCAST=n BATMAN_V=y * unused_symbols cfg: BLA=n DAT=n DEBUG=y TRACING=n NC=y MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=n DAT=n DEBUG=y TRACING=y NC=n MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=n DAT=n DEBUG=y TRACING=y NC=y MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=n DAT=y DEBUG=n TRACING=n NC=y MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=n DAT=y DEBUG=n TRACING=n NC=y MCAST=n BATMAN_V=y * unused_symbols cfg: BLA=n DAT=y DEBUG=n TRACING=y NC=n MCAST=n BATMAN_V=y * unused_symbols cfg: BLA=n DAT=y DEBUG=y TRACING=n NC=n MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=n DAT=y DEBUG=y TRACING=n NC=y MCAST=n BATMAN_V=y * unused_symbols cfg: BLA=n DAT=y DEBUG=y TRACING=y NC=n MCAST=n BATMAN_V=y * unused_symbols cfg: BLA=n DAT=y DEBUG=y TRACING=y NC=y MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=n DAT=y DEBUG=y TRACING=y NC=y MCAST=n BATMAN_V=y * unused_symbols cfg: BLA=y DAT=n DEBUG=n TRACING=n NC=n MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=y DAT=n DEBUG=n TRACING=n NC=y MCAST=n BATMAN_V=y * unused_symbols cfg: BLA=y DAT=n DEBUG=n TRACING=y NC=n MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=y DAT=n DEBUG=y TRACING=n NC=n MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=y DAT=n DEBUG=y TRACING=n NC=y MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=y DAT=n DEBUG=y TRACING=n NC=y MCAST=n BATMAN_V=y * unused_symbols cfg: BLA=y DAT=n DEBUG=y TRACING=y NC=y MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=y DAT=y DEBUG=n TRACING=n NC=n MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=y DAT=y DEBUG=n TRACING=n NC=y MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=y DAT=y DEBUG=n TRACING=y NC=n MCAST=n BATMAN_V=y * unused_symbols cfg: BLA=y DAT=y DEBUG=n TRACING=y NC=y MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=y DAT=y DEBUG=y TRACING=n NC=n MCAST=n BATMAN_V=n * unused_symbols cfg: BLA=y DAT=y DEBUG=y TRACING=n NC=n MCAST=n BATMAN_V=y * unused_symbols cfg: BLA=y DAT=y DEBUG=y TRACING=y NC=n MCAST=n BATMAN_V=y
batadv_softif_get_bridge
I am guessing I must just ignore the latter because it is only relevant for non-mcast build and the noise from the extra #ifdef around "static" isn't worth it.
The the linux/net.h "dependency" came with the second patch
Btw. I am still waiting for reviews from Antonio
Kind regards, Sven