On Tuesday, May 28, 2013 23:42:48 Simon Wunderlich wrote:
On Tue, May 28, 2013 at 05:32:32PM +0200, Matthias Schiffer wrote:
The rtnl_lock in batadv_store_mesh_iface has been converted to a rtnl_trylock some time ago to avoid a possible deadlock between rtnl and s_active on removal of the sysfs nodes.
The behaviour introduced by that was quite confusing as it could lead to the sysfs store to fail, making batman-adv setup scripts unreliable. As recently the sysfs removal was postponed to a worker not running with the rtnl taken, the deadlock can't occur any more and it is safe to change the trylock back to a lock to make the sysfs store reliable again.
Signed-off-by: Matthias Schiffer mschiffer@universe-factory.net
Reviewed-by: Simon Wunderlich siwu@hrz.tu-chemnitz.de
Applied in revision 96cd772.
Thanks, Marek