16 Jun
2011
16 Jun
'11
10:12 a.m.
On Thursday, June 16, 2011 12:43:55 AM Antonio Quartulli wrote:
- tt_local_add(soft_iface, soft_iface->dev_addr);
- tt_local_add(soft_iface, soft_iface->dev_addr, NULL_IFINDEX);
Are you sure 0 is not a valid index for any interface ?
Yes. You can also check the function dev_new_index() at http://lxr.linux.no/linux+v2.6.39/net/core/dev.c#L5080 indexes start from 1 :)
Ok.
How about adding a set of flags (TT_CLIENT_ROAM / TT_CLIENT_WIFI / etc) instead of adding more and more bool arguments ? In several places the code converts one to the other which does not seem necessary.
You mean simply passing a int value which is combination of the used flags? mught be a good idea, even for further changes.
Yes, that is what I had in mind.
Regards, Marek