B.A.T.M.A.N

b.a.t.m.a.n@lists.open-mesh.org

15 participants
4308 discussions

[B.A.T.M.A.N.] patch for manpage batctl.8: Missing description of gw_mode sel_class for B.A.T.M.A.N. V
by Ruben 28 Nov '18

28 Nov '18

This will resolve https://www.open-mesh.org/issues/366 --- /tmp/smartgit7095787147690981841tmp/compare__827356725346254060_batctl.8 +++ /tmp/smartgit7095787147690981841tmp/compare__6833548133995178090_batctl.8 @@ -144,6 +144,9 @@ If the node is a gateway client the parameter will decide which criteria to consider when the batman-adv module has to choose between different internet connections announced by the aforementioned servers. .RE +.RS 9 +B.A.T.M.A.N. IV: +.RE .RS 17 default: 20 \-> late switch (TQ 20) .RE @@ -166,6 +169,19 @@ .RS 7 chooses the gateway with the best link quality but switches to another gateway as soon as a better one is found which is at least XX TQ better than the currently selected gateway (XX has to be a number between 3 and 256). +.RE +.RE +.RS 9 +B.A.T.M.A.N. V: +.RE +.RS 17 +default: 5000 \-> late switch (5000 kbit/s throughput) +example: 1500 \-> fast switch connection +.RS 16 +switches to another gateway as soon as a better one is found which is at least +1500 kbit/s faster throughput than the currently selected gateway. Throughput is +determined by evaluating which is lower: the advertised throughput by the +gateway or the maximum bandwidth across the entire path. .RE .RE .br

4 4

[B.A.T.M.A.N.] [RFC v3 0/4] batctl: netlink restructuring, part 3
by Sven Eckelmann 24 Nov '18

24 Nov '18

As mentioned earlier, the netlink config restructuring in batctl will be splitted in multiple steps. The first step was already merged and the RFC changes for the netlink interface in batman-adv were just posted. The batman-adv weren't directly rejected by Jiro and thus I've started to convert all settings to netlink while still allowing sysfs as fallback. v3: * fix kernel-doc in batman_adv.h * add three patches to use the netlink interface with the already existing setting commands v2: * drop of generic config command * reimplementation of the event command Sven Eckelmann (4): batctl: Add support for config mcast group in event monitor batctl: Don't allocate new buffer for vlan parent device batctl: Automatically translate vlan to mesh_iface batctl: Use netlink as new configuration interface aggregation.c | 45 ++++- ap_isolation.c | 67 ++++++- batman_adv.h | 188 +++++++++++++++++- bonding.c | 45 ++++- bridge_loop_avoidance.c | 46 ++++- distributed_arp_table.c | 46 ++++- event.c | 234 ++++++++++++++++++++++ fragmentation.c | 45 ++++- functions.c | 160 +++++++++++++--- functions.h | 24 ++- gateways.c | 10 +- gw_mode.c | 415 +++++++++++++++++++++++++++++++--------- isolation_mark.c | 123 +++++++++++- loglevel.c | 138 ++++++++++--- main.c | 10 +- main.h | 6 +- mcast_flags.c | 10 +- multicast_mode.c | 45 ++++- netlink.c | 108 ++++++++++- netlink.h | 2 + network_coding.c | 45 ++++- orig_interval.c | 84 +++++++- originators.c | 10 +- routing_algo.c | 1 - sys.c | 220 ++++++++++++++++----- sys.h | 26 ++- 26 files changed, 1897 insertions(+), 256 deletions(-) -- 2.19.1

1 4

[B.A.T.M.A.N.] [RFC v2 00/19] batman-adv: netlink restructuring, part 2
by Sven Eckelmann 24 Nov '18

24 Nov '18

Hi, Jiri Pirko called the batman-adv configuration interface a while back "a huge mistake" [1] and suggested genl as alternative. The first reimplementation [2] (based on the team/devlink design) was rejected. This second implementation is now using a nl80211-like design. The objects which can now be modified/queried are: * mesh/soft-interface (BATADV_CMD_GET_MESH/BATADV_CMD_SET_MESH) * slave/hard-interface (BATADV_CMD_GET_HARDIF/BATADV_CMD_SET_HARDIF) * vlan (BATADV_CMD_GET_VLAN/BATADV_CMD_SET_VLAN) Such a set messages automatically triggers a *_SET_* "reply" via the config multicast group. The same behavior was also added to the sysfs interface. Luckily, Jiri Pirko told us that he will have a look at patches. I would also like to ask the other developers to check whether their configuration values are represented correctly. And please also check whether the current implementation might collide with some other features which you might have in your pipeline. v2: * rewrite everything in a more nl80211-like message/attribute format. Kind regards, Sven [1] https://www.open-mesh.org/issues/300 [2] https://patchwork.open-mesh.org/cover/17610/ Sven Eckelmann (19): batman-adv: Move common genl doit code pre/post hooks batman-adv: Prepare framework for mesh genl config batman-adv: Prepare framework for hardif genl config batman-adv: Prepare framework for vlan genl config batman-adv: Add aggregated_ogms mesh genl configuration batman-adv: Add ap_isolation mesh/vlan genl configuration batman-adv: Add bonding mesh genl configuration batman-adv: Add bridge_loop_avoidance mesh genl configuration batman-adv: Add distributed_arp_table mesh genl configuration batman-adv: Add fragmentation mesh genl configuration batman-adv: Add gateway mesh genl configuration batman-adv: Add hop_penalty mesh genl configuration batman-adv: Add log_level mesh genl configuration batman-adv: Add multicast_mode mesh genl configuration batman-adv: Add network_coding mesh genl configuration batman-adv: Add orig_interval mesh genl configuration batman-adv: Add elp_interval hardif genl configuration batman-adv: Add throughput_override hardif genl configuration batman-adv: Trigger genl notification on sysfs config change include/uapi/linux/batman_adv.h | 188 +++++- net/batman-adv/gateway_client.c | 1 - net/batman-adv/gateway_common.c | 1 + net/batman-adv/gateway_common.h | 6 - net/batman-adv/netlink.c | 1074 +++++++++++++++++++++++++++---- net/batman-adv/netlink.h | 6 + net/batman-adv/soft-interface.c | 2 +- net/batman-adv/sysfs.c | 64 +- 8 files changed, 1195 insertions(+), 147 deletions(-) -- 2.19.1

2 24

[B.A.T.M.A.N.] [RFC v2 0/1] batctl: netlink restructuring, part 3
by Sven Eckelmann 23 Nov '18

23 Nov '18

As mentioned earlier, the netlink config restructuring in batctl will be splitted in multiple steps. The first step was already merged and the RFC changes for the netlink interface in batman-adv were just posted. It doesn't make sense to have a full implementation in batctl when the batman-adv part is not yet in a state which survived the RFC phase. But it also is useless to have only the batman-adv RFC part without at least something in userspace. I have now only added the event monitor so it is possible to at least parse the messages from the kernel. An implementation of the sysfs config helper with netlink support (and sysfs fallback) will be implemented when the RFC phase of the batman-adv part doesn't require any major changes anymore. v2: * drop of generic config command * reimplementation of the event command Kind regards, Sven Sven Eckelmann (1): batctl: Add support for config mcast group in event monitor batman_adv.h | 188 +++++++++++++++++++++++++++++++++++++++-- event.c | 234 +++++++++++++++++++++++++++++++++++++++++++++++++++ netlink.c | 20 +++++ 3 files changed, 437 insertions(+), 5 deletions(-) -- 2.19.1

1 1

[B.A.T.M.A.N.] [PATCH 0/2] pull request for net: batman-adv 2018-11-14
by Simon Wunderlich 17 Nov '18

17 Nov '18

Hi David, here are some bugfixes which we would like to see integrated into net. Please pull or let me know of any problem! Thank you, Simon The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-net-for-davem-20181114 for you to fetch changes up to d7d8bbb40a5b1f682ee6589e212934f4c6b8ad60: batman-adv: Expand merged fragment buffer for full packet (2018-11-12 10:41:29 +0100) ---------------------------------------------------------------- Here are two batman-adv bugfixes: - Explicitly pad short ELP packets with zeros, by Sven Eckelmann - Fix packet size calculation when merging fragments, by Sven Eckelmann ---------------------------------------------------------------- Sven Eckelmann (2): batman-adv: Use explicit tvlv padding for ELP packets batman-adv: Expand merged fragment buffer for full packet net/batman-adv/bat_v_elp.c | 6 ++++-- net/batman-adv/fragmentation.c | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-)

2 3

[B.A.T.M.A.N.] [PATCH 00/16] pull request for net-next: batman-adv 2018-11-14
by Simon Wunderlich 16 Nov '18

16 Nov '18

Hi David, here is a feature/cleanup pull request of batman-adv to go into net-next. Please pull or let me know of any problem! Thank you, Simon The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-next-for-davem-20181114 for you to fetch changes up to 016fd285682952b943641c074d1cc0d02b3e6889: batman-adv: enable MCAST by default at compile time (2018-11-12 10:41:51 +0100) ---------------------------------------------------------------- This feature/cleanup patchset includes the following patches: - Bump version strings, by Simon Wunderlich - Fixup includes, by Sven Eckelmann (3 patches) - Separate BATMAN_ADV_DEBUG from DEBUGFS, by Sven Eckelmann - Fixup tracing log documentation, by Sven Eckelmann - Use exclusive locks to secure netlink information dump transfers, by Sven Eckelmann (8 patches) - Move CRC16 dependency, by Sven Eckelmann - Enable MCAST by default, by Linus Luessing ---------------------------------------------------------------- Linus Lüssing (1): batman-adv: enable MCAST by default at compile time Simon Wunderlich (1): batman-adv: Start new development cycle Sven Eckelmann (14): batman-adv: Drop unused lockdep include batman-adv: Add includes for deprecation warning batman-adv: Improve includes for trace functionality batman-adv: Allow to use BATMAN_ADV_DEBUG without BATMAN_ADV_DEBUGFS batman-adv: Fix description for BATMAN_ADV_DEBUG batman-adv: Add inconsistent gateway netlink dump detection batman-adv: Add inconsistent hardif netlink dump detection batman-adv: Store modification counter via hash helpers batman-adv: Add inconsistent backbone netlink dump detection batman-adv: Add inconsistent claim netlink dump detection batman-adv: Add inconsistent dat netlink dump detection batman-adv: Add inconsistent local TT netlink dump detection batman-adv: Add inconsistent multicast netlink dump detection batman-adv: Move CRC16 dependency to BATMAN_ADV_BLA net/batman-adv/Kconfig | 10 +++-- net/batman-adv/bat_iv_ogm.c | 25 ++++++----- net/batman-adv/bat_v.c | 26 +++++++---- net/batman-adv/bridge_loop_avoidance.c | 82 +++++++++++++++++++--------------- net/batman-adv/debugfs.c | 2 + net/batman-adv/distributed-arp-table.c | 42 +++++++++-------- net/batman-adv/gateway_client.c | 3 ++ net/batman-adv/hard-interface.c | 3 ++ net/batman-adv/hash.c | 2 + net/batman-adv/hash.h | 6 +++ net/batman-adv/log.c | 60 ++++++++++++++----------- net/batman-adv/main.c | 3 ++ net/batman-adv/main.h | 3 +- net/batman-adv/multicast.c | 51 +++++++++++---------- net/batman-adv/netlink.c | 24 +++++----- net/batman-adv/trace.c | 2 - net/batman-adv/trace.h | 6 +++ net/batman-adv/translation-table.c | 41 +++++++++-------- net/batman-adv/types.h | 5 ++- 19 files changed, 236 insertions(+), 160 deletions(-)

2 17

[B.A.T.M.A.N.] broadcast storms
by Jake.Harris＠zf.com 13 Nov '18

13 Nov '18

I'm sure a similar question to this has been answered, but I am new to this mailing list format and don't know an efficient way to search https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/ I'm having problems with broadcast messages effectively echoing around the network of 50ish nodes. I attached a few seconds of the batctl tcpdump output. I can't seem to find a pattern to what causes this, it tends to happen once every two or three weeks, the storm causes problems with the batman program where during the storm nodes drop all their neighbors (batctl n shows an empty list) indefinitely, which I have worked around that issue via a batch script that reloads batman if the neighbor list is empty. Reloading successfully reconnects to the network but the storm still persists. The only way I've found to fix this is to reboot all the nodes at the same time such that the whole network is down to kill the echos. I believe I had this problem much more frequently (every 4 days or so) a while ago on the same network when using discrete tcp destinations for the nodes to communicate, the storm frequency was reduced to what it is now by using broadcast packets and reducing the communication rate from 12 seconds to once every 40 seconds. Rebooting the nodes that are responsible for the echoing messages has no effect, I rebooted 192.168.1.230 before running tcpdump that is attached and as it shows packets from 230 continued to bounce around while the node was powered off and after it rejoined the network. It doesn't appear broadcast uses a time-to-live parameter to limit the hops the packets will make. I'm at a loss for a way to remedy this, there seems to only be multicast optimizations.

2 7

[B.A.T.M.A.N.] [PATCH 3.16 142/366] cfg80211: initialize sinfo in cfg80211_get_station
by Ben Hutchings 11 Nov '18

11 Nov '18

3.16.61-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Sven Eckelmann <sven(a)narfation.org> commit 3c12d0486856b9eb89c2a9ac336713cba90813e3 upstream. Most of the implementations behind cfg80211_get_station will not initialize sinfo to zero before manipulating it. For example, the member "filled", which indicates the filled in parts of this struct, is often only modified by enabling certain bits in the bitfield while keeping the remaining bits in their original state. A caller without a preinitialized sinfo.filled can then no longer decide which parts of sinfo were filled in by cfg80211_get_station (or actually the underlying implementations). cfg80211_get_station must therefore take care that sinfo is initialized to zero. Otherwise, the caller may tries to read information which was not filled in and which must therefore also be considered uninitialized. In batadv_v_elp_get_throughput's case, an invalid "random" expected throughput may be stored for this neighbor and thus the B.A.T.M.A.N V algorithm may switch to non-optimal neighbors for certain destinations. Fixes: 7406353d43c8 ("cfg80211: implement cfg80211_get_station cfg80211 API") Reported-by: Thomas Lauer <holminateur(a)gmail.com> Reported-by: Marcel Schmidt <ff.z-casparistrasse(a)mailbox.org> Cc: b.a.t.m.a.n(a)lists.open-mesh.org Signed-off-by: Sven Eckelmann <sven(a)narfation.org> Signed-off-by: Johannes Berg <johannes(a)sipsolutions.net> Signed-off-by: Ben Hutchings <ben(a)decadent.org.uk> --- net/wireless/util.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/wireless/util.c +++ b/net/wireless/util.c @@ -1566,6 +1566,8 @@ int cfg80211_get_station(struct net_devi if (!rdev->ops->get_station) return -EOPNOTSUPP; + memset(sinfo, 0, sizeof(*sinfo)); + return rdev_get_station(rdev, dev, mac_addr, sinfo); } EXPORT_SYMBOL(cfg80211_get_station);

1 0

[B.A.T.M.A.N.] [PATCH maint] batman-adv: Expand merged fragment buffer for full packet
by Sven Eckelmann 07 Nov '18

07 Nov '18

The complete size ("total_size") of the fragmented packet is stored in the fragment header and in the size of the fragment chain. When the fragments are ready for merge, the skbuff's tail of the first fragment is expanded to have enough room after the data pointer for at least total_size. This means that it gets expanded by total_size - first_skb->len. But this is ignoring the fact that after expanding the buffer, the fragment header is pulled by from this buffer. Assuming that the tailroom of the buffer was already 0, the buffer after the data pointer of the skbuff is now only total_size - len(fragment_header) large. When the merge function is then processing the remaining fragments, the code to copy the data over to the merged skbuff will cause an skb_over_panic when it tries to actually put enough data to fill the total_size bytes of the packet. The size of the skb_pull must therefore also be taken into account when the buffer's tailroom is expanded. Fixes: 9b3eab61754d ("batman-adv: Receive fragmented packets and merge") Reported-by: Martin Weinelt <martin(a)darmstadt.freifunk.net> Co-authored-by: Linus Lüssing <linus.luessing(a)c0d3.blue> Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- Cc: Martin Weinelt <martin(a)darmstadt.freifunk.net> --- net/batman-adv/fragmentation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/fragmentation.c b/net/batman-adv/fragmentation.c index 0fddc171..5b71a289 100644 --- a/net/batman-adv/fragmentation.c +++ b/net/batman-adv/fragmentation.c @@ -275,7 +275,7 @@ batadv_frag_merge_packets(struct hlist_head *chain) kfree(entry); packet = (struct batadv_frag_packet *)skb_out->data; - size = ntohs(packet->total_size); + size = ntohs(packet->total_size) + hdr_size; /* Make room for the rest of the fragments. */ if (pskb_expand_head(skb_out, 0, size - skb_out->len, GFP_ATOMIC) < 0) { -- 2.19.1

1 0

[B.A.T.M.A.N.] [PATCH] batman-adv: enable MCAST by default at compile time
by Linus Lüssing 06 Nov '18

06 Nov '18

Thanks to rigorous testing in wireless community mesh networks several issues with multicast entries in the translation table were found and fixed in the last 1.5 years. Now we see the first larger networks (a few hundred nodes) with a batman-adv version with multicast optimizations enabled arising, with no TT / multicast optimization related issues so far. Therefore it seems safe to enable multicast optimizations by default not only in kernel module builds but also for in-kernel builds. Signed-off-by: Linus Lüssing <linus.luessing(a)c0d3.blue> --- net/batman-adv/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig index f75816f5..b70b96cd 100644 --- a/net/batman-adv/Kconfig +++ b/net/batman-adv/Kconfig @@ -82,6 +82,7 @@ config BATMAN_ADV_NC config BATMAN_ADV_MCAST bool "Multicast optimisation" depends on BATMAN_ADV && INET && !(BRIDGE=m && BATMAN_ADV=y) + default y help This option enables the multicast optimisation which aims to reduce the air overhead while improving the reliability of -- 2.11.0

2 1

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N