B.A.T.M.A.N

b.a.t.m.a.n@lists.open-mesh.org

15 participants
4308 discussions

[B.A.T.M.A.N.] Problem after configuring a bridge
by Dr. Stefan Radtke 23 Feb '11

23 Feb '11

Hello *, I set up batman-adv-2010 on OpenWRT (backfire 10.3.x). Mesh interface is wlan0 and another non-batman-LAN is connected to eth0. non-batman clients should connect via the eth0 interface. (Full description and network diagram here: https://forum.openwrt.org/viewtopic.php?pid=129226#p129226 ). After setting up batman-adv 2010.x with batctl if add wlan0 ifconfig wlan 0 0.0.0.0 ifconfig bat0 192.168.10.2 (previous ip address of wlan0) ifconfig bat0 up I have to configure a bridge (according to quick start guide http://www.open-mesh.org/wiki/batman-adv-quick-start-guide) because I want batman-adv to announce MAC-addresses connected to eth0 (see network diagram): brctl addbr mesh-bridge brctl addif mesh-bridge eth0 brctl addif mesh-bridge bat0 ifconfig eth0 up ifconfig bat0 up ifconfig mesh-bridge up Although the translation tables (global and local) seem fine in this moment, at the same momentof bringing up the bridge I cannot send any more packets through bat0 or ent0. Both don't even reply to a ping. Network setup and outputs of ifconfig onhttp://www.open-mesh.org/wiki/batman-adv-quick-start-guide Any hint is appreciated. Stefan

3 4

[B.A.T.M.A.N.] Wireless Battle Mesh v4 - Call for papers
by Marek Lindner 22 Feb '11

22 Feb '11

Wireless Battle Mesh v4 - Call for papers ========================= Wireless Battle Mesh v4 is at hand and it is time to bring together the agenda. To avoid last year's dynamic process which gave us a true talk marathon on the very last day of WBMv3 all talks / workshops / panel discussions shall be announced beforehand. Tracks ==== In order to broaden the horizon of the event we are going to split the event into different tracks: * The technical track is taking place throughout the week (monday till friday) which mainly focuses on rather technical topics like: => routing protocol internals => implementations / development of "cool" algorithms => hands-on routing / multicast / roaming / convergence speed / etc => secuity aspects in mesh networks => your idea here * The weekend (saturday & sunday) is reserved for the applications track which aims to showcase applications that run on top of the mesh. It is not important whether protocol X or Y is deployed and how it is implemented, the question is: What can we do with the mesh once it is there ? => VoIP in the mesh ? => fast desaster recovery ? => artistic projects ? => your idea here The idea of these tracks is to provide a ground for the different developers / projects to exchange ideas on technical aspects of algorithms / implementations / optimizations as well as organizing an exchange with mesh network users who care less about how the mesh itself works as long as their application can do its job. On the other hand the weekend serves as an entry point for people to learn about what you can actually do with mesh networks. Submission ======= To allow an efficient handling of your submission, please provide the following information and send them to me directly in form of an email: * your name * the track you are interested in * the type of your slot (talk/workshop/panel discussion) * your topic headline * your topic description which can brief (does not need to exceed a couple of lines) but should provide a reasonable summary of your talk * the dates of your stay at the event + (optional) preferred day for your slot * length of the slot if you wish to do a workshop (all other slots will be limited to one hour - notify me in advance if you think that is not enough for you) Deadlines ====== Submissions are accepted until and including the 28th of February. Everyone missing this deadline still has the opportunity to apply for a lightening talk slot. These slots can be acquired by simply contacting me during the event. The list of registered lightening talks will be published in the battlemesh wiki. The final program will be made available in the aforementioned wiki during the first week of March. If you have any question or suggestion, please let me know. Regards, Marek

4 5

[B.A.T.M.A.N.] renaming batman_if
by Marek Lindner 18 Feb '11

18 Feb '11

Hi, due to popular request I'm proposing 2 patches to rename "batman_if" to "hard_iface". The former was rather confusing/misleading whereas the latter expresses its function clearly. Note: As this struct is used all over the code it will create quite a rebase effort for everyone with external patches. Keep in mind that "sed" is your friend. ;-) Cheers, Marek

1 3

[B.A.T.M.A.N.] reordered rcu (part II)
by Marek Lindner 18 Feb '11

18 Feb '11

Hi, here comes the next batch of changes to make the code "rcu safe". It won't be the last one but should make all follow-ups much easier. Regards, Marek

2 8

[B.A.T.M.A.N.] [PATCH] batman-adv: Fix possible buffer overflow in softif neigh list output
by Linus Lüssing 18 Feb '11

18 Feb '11

When printing the soft interface table the number of entries in the softif neigh list are first being counted and a fitting buffer allocated. After that the softif neigh list gets locked again and the buffer printed - which has the following two issues: For one thing, the softif neigh list might have grown when reacquiring the rcu lock, which results in writing outside of the allocated buffer. For another, only 30 Bytes per soft interface neighbor are allocated, but up to 31 Bytes get copied into the buffer which leads to a buffer overflow again if the vid needs more than one digit. Furthermore 31 Bytes are not enough for printing an entry with a vid of more than 2 digits. The manual buffering is unnecessary, we can safely print to the seq directly during the rcu_read_lock(). Signed-off-by: Linus Lüssing <linus.luessing(a)ascom.ch> --- soft-interface.c | 22 +--------------------- 1 files changed, 1 insertions(+), 21 deletions(-) diff --git a/soft-interface.c b/soft-interface.c index bd8b539..e543d09 100644 --- a/soft-interface.c +++ b/soft-interface.c @@ -173,8 +173,6 @@ int softif_neigh_seq_print_text(struct seq_file *seq, void *offset) struct bat_priv *bat_priv = netdev_priv(net_dev); struct softif_neigh *softif_neigh; struct hlist_node *node; - size_t buf_size, pos; - char *buff; if (!bat_priv->primary_if) { return seq_printf(seq, "BATMAN mesh %s disabled - " @@ -184,33 +182,15 @@ int softif_neigh_seq_print_text(struct seq_file *seq, void *offset) seq_printf(seq, "Softif neighbor list (%s)\n", net_dev->name); - buf_size = 1; - /* Estimate length for: " xx:xx:xx:xx:xx:xx\n" */ rcu_read_lock(); hlist_for_each_entry_rcu(softif_neigh, node, &bat_priv->softif_neigh_list, list) - buf_size += 30; - rcu_read_unlock(); - - buff = kmalloc(buf_size, GFP_ATOMIC); - if (!buff) - return -ENOMEM; - - buff[0] = '\0'; - pos = 0; - - rcu_read_lock(); - hlist_for_each_entry_rcu(softif_neigh, node, - &bat_priv->softif_neigh_list, list) { - pos += snprintf(buff + pos, 31, "%s %pM (vid: %d)\n", + seq_printf(seq, "%s %pM (vid: %d)\n", bat_priv->softif_neigh == softif_neigh ? "=>" : " ", softif_neigh->addr, softif_neigh->vid); - } rcu_read_unlock(); - seq_printf(seq, "%s", buff); - kfree(buff); return 0; } -- 1.7.2.3

3 2

[B.A.T.M.A.N.] HNAs Announcements and Roaming management v2]
by Antonio Quartulli 18 Feb '11

18 Feb '11

Hello to everyone, This is the second version of the HNAs announcement mechanism/Roaming management paper. Please, consider it still a draft. A lot of things have changed since the previous version of this paper. As usual, feel free to comment it. I'll wait for your feedback :) Link: http://www.open-mesh.org/attachment/wiki/hna-improvements/handover.pdf Ragards, -- Antonio Quartulli ..each of us alone is worth nothing.. Ernesto "Che" Guevara

2 2

[B.A.T.M.A.N.] Redundancy bonding mode patches, v1
by Linus Lüssing 16 Feb '11

16 Feb '11

Hi everyone, The following patches add a redundancy bonding mode to batman-adv: In case of multiple interfaces available towards a next hop node, instead of sending packets in interface alternating or round robin bonding fashion, packets get send redundantly on all available interfaces available for bonding. This mode increases the packet delivery ratio of unicast data transfers for the cost of throughput in multi interface mesh networks and is therefore aimed at high reliability mesh networks. It is especially useful if the main source of packet loss is not always reliably detectable by batman-adv's broadcast PDR measurements (i.e. bursty periods of interference on a single channel, which gets averaged out due to the windowing; different unicast bitrate; ...). Or if a fault tolerant packet forwarding scheme which is able to tolerate a sudden link failure with no impact on the user experience is required. The first eight patches are mainly some restructuring of the unicast sending code paths. Patches nine to 13 add the actual redandancy bonding mode. Please note, that this redundancy bonding mode is not yet compatible with batman-adv's link layer fragmentation feature. Cheers, Linus

3 17

[B.A.T.M.A.N.] [PATCH][trivial] Batman: Remove two duplicate includes.
by Jesper Juhl 14 Feb '11

14 Feb '11

Remove duplicate inclusion of "send.h" and "routing.h" from net/batman-adv/soft-interface.c Patch is against linux-next as of today. Signed-off-by: Jesper Juhl <jj(a)chaosbits.net> --- soft-interface.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index bd088f8..7e37077 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -29,14 +29,12 @@ #include "hash.h" #include "gateway_common.h" #include "gateway_client.h" -#include "send.h" #include "bat_sysfs.h" #include <linux/slab.h> #include <linux/ethtool.h> #include <linux/etherdevice.h> #include <linux/if_vlan.h> #include "unicast.h" -#include "routing.h" static int bat_get_settings(struct net_device *dev, struct ethtool_cmd *cmd); -- Jesper Juhl <jj(a)chaosbits.net> http://www.chaosbits.net/ Plain text mails only, please. Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html

2 1

[B.A.T.M.A.N.] [PATCH] batman-adv: else should follow close brace '}'
by Sven Eckelmann 14 Feb '11

14 Feb '11

Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- batman-adv/gateway_client.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/batman-adv/gateway_client.c b/batman-adv/gateway_client.c index 3486854..41eba8a 100644 --- a/batman-adv/gateway_client.c +++ b/batman-adv/gateway_client.c @@ -123,8 +123,7 @@ void gw_election(struct bat_priv *bat_priv) "Removing selected gateway - " "no gateway in range\n"); gw_deselect(bat_priv); - } - else + } else rcu_read_unlock(); return; -- 1.7.2.3

2 1

[B.A.T.M.A.N.] Reordered rcu refcounting
by Sven Eckelmann 13 Feb '11

13 Feb '11

Hi, I told Linus and Marek that the implementation of some datastructures using reference counting and RCUs must be redesigned. The problem is that call_rcu should only be used when the reference count is zero because multiple call_rcu cannot be initiated at the same time. The next problem is that we may try to access an element with the refcount 0 when we try to traverse a rcu protected list. This problem cannot be solved by kref - thus we have to use atomic_t again to _not_ increase the reference count when it was already zero. Marek asked me what we must change - I try to summarize those things in the following patches. They aren't tested and should only be seen as suggestions what must be done to finish the "remove orig_hash lock"-patches. If you try these patches then please keep in mind that they will sell your soul to the next confectioner (for some cookies or a pie). More information can be found inside Documentation/RCU/rcuref.txt Btw, maybe I've found a bug inside the find_router with enabled bonding (see "BUG" in patch 4). Best regards, Sven

5 43

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N