B.A.T.M.A.N

b.a.t.m.a.n@lists.open-mesh.org

15 participants
4308 discussions

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Replace simple function like defines with functions
by Sven Eckelmann 13 May '12

13 May '12

Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- bat_debugfs.c | 5 +--- distributed-arp-table.c | 75 +++++++++++++++++++++++++++++++++-------------- distributed-arp-table.h | 8 ----- main.h | 37 +++++++++++++++-------- 4 files changed, 79 insertions(+), 46 deletions(-) diff --git a/bat_debugfs.c b/bat_debugfs.c index 004d94f..b4d622b 100644 --- a/bat_debugfs.c +++ b/bat_debugfs.c @@ -74,16 +74,13 @@ static int batadv_fdebug_log(struct debug_log *debug_log, const char *fmt, ...) return 0; } -int batadv_debug_log(struct bat_priv *bat_priv, const char *fmt, ...) +int batadv_debug_log(struct bat_priv *bat_priv, const char *fmt, va_list args) { - va_list args; char tmp_log_buf[256]; - va_start(args, fmt); vscnprintf(tmp_log_buf, sizeof(tmp_log_buf), fmt, args); batadv_fdebug_log(bat_priv->debug_log, "[%10u] %s", jiffies_to_msecs(jiffies), tmp_log_buf); - va_end(args); return 0; } diff --git a/distributed-arp-table.c b/distributed-arp-table.c index 07ef1fe..ebe9969 100644 --- a/distributed-arp-table.c +++ b/distributed-arp-table.c @@ -32,6 +32,31 @@ #include "translation-table.h" #include "unicast.h" +static uint8_t *batadv_arp_hw_src(struct sk_buff *skb, int hdr_size) +{ + uint8_t *addr; + + addr = (uint8_t *)(skb->data + hdr_size); + addr += ETH_HLEN + sizeof(struct arphdr); + + return addr; +} + +static __be32 batadv_arp_ip_src(struct sk_buff *skb, int hdr_size) +{ + return *(__be32 *)(batadv_arp_hw_src(skb, hdr_size) + ETH_ALEN); +} + +static uint8_t *batadv_arp_hw_dst(struct sk_buff *skb, int hdr_size) +{ + return batadv_arp_hw_src(skb, hdr_size) + ETH_ALEN + 4; +} + +static __be32 batadv_arp_ip_dst(struct sk_buff *skb, int hdr_size) +{ + return *(__be32 *)(batadv_arp_hw_src(skb, hdr_size) + ETH_ALEN * 2 + 4); +} + /* hash function to choose an entry in a hash table of given size. * hash algorithm from http://en.wikipedia.org/wiki/Hash_table */ @@ -60,14 +85,19 @@ static void batadv_dbg_arp(struct bat_priv *bat_priv, struct sk_buff *skb, uint16_t type, int hdr_size, char *msg) { struct unicast_4addr_packet *unicast_4addr_packet; + __be32 src_ip, dst_ip; if (msg) batadv_dbg(DBG_DAT, bat_priv, "%s\n", msg); + src_ip = batadv_arp_ip_src(skb, hdr_size); + dst_ip = batadv_arp_ip_dst(skb, hdr_size); batadv_dbg(DBG_DAT, bat_priv, "ARP MSG = [src: %pM-%pI4 dst: %pM-%pI4]\n", - ARP_HW_SRC(skb, hdr_size), &ARP_IP_SRC(skb, hdr_size), - ARP_HW_DST(skb, hdr_size), &ARP_IP_DST(skb, hdr_size)); + batadv_arp_hw_src(skb, hdr_size), + &src_ip, + batadv_arp_hw_dst(skb, hdr_size), + &dst_ip); if (hdr_size == 0) return; @@ -383,8 +413,8 @@ static uint16_t batadv_arp_get_type(struct bat_priv *bat_priv, /* Check for bad reply/request. If the ARP message is not sane, DAT * will simply ignore it */ - ip_src = ARP_IP_SRC(skb, hdr_size); - ip_dst = ARP_IP_DST(skb, hdr_size); + ip_src = batadv_arp_ip_src(skb, hdr_size); + ip_dst = batadv_arp_ip_dst(skb, hdr_size); if (ipv4_is_loopback(ip_src) || ipv4_is_multicast(ip_src) || ipv4_is_loopback(ip_dst) || ipv4_is_multicast(ip_dst)) goto out; @@ -418,9 +448,9 @@ bool batadv_dat_snoop_outgoing_arp_request(struct bat_priv *bat_priv, batadv_dbg_arp(bat_priv, skb, type, 0, "Parsing outgoing ARP REQUEST"); - ip_src = ARP_IP_SRC(skb, 0); - hw_src = ARP_HW_SRC(skb, 0); - ip_dst = ARP_IP_DST(skb, 0); + ip_src = batadv_arp_ip_src(skb, 0); + hw_src = batadv_arp_hw_src(skb, 0); + ip_dst = batadv_arp_ip_dst(skb, 0); primary_if = batadv_primary_if_get_selected(bat_priv); if (!primary_if) @@ -480,9 +510,9 @@ bool batadv_dat_snoop_incoming_arp_request(struct bat_priv *bat_priv, if (type != ARPOP_REQUEST) goto out; - hw_src = ARP_HW_SRC(skb, hdr_size); - ip_src = ARP_IP_SRC(skb, hdr_size); - ip_dst = ARP_IP_DST(skb, hdr_size); + hw_src = batadv_arp_hw_src(skb, hdr_size); + ip_src = batadv_arp_ip_src(skb, hdr_size); + ip_dst = batadv_arp_ip_dst(skb, hdr_size); batadv_dbg_arp(bat_priv, skb, type, hdr_size, "Parsing incoming ARP REQUEST"); @@ -538,10 +568,10 @@ bool batadv_dat_snoop_outgoing_arp_reply(struct bat_priv *bat_priv, batadv_dbg_arp(bat_priv, skb, type, 0, "Parsing outgoing ARP REPLY"); - hw_src = ARP_HW_SRC(skb, 0); - ip_src = ARP_IP_SRC(skb, 0); - hw_dst = ARP_HW_DST(skb, 0); - ip_dst = ARP_IP_DST(skb, 0); + hw_src = batadv_arp_hw_src(skb, 0); + ip_src = batadv_arp_ip_src(skb, 0); + hw_dst = batadv_arp_hw_dst(skb, 0); + ip_dst = batadv_arp_ip_dst(skb, 0); batadv_arp_neigh_update(bat_priv, ip_src, hw_src); batadv_arp_neigh_update(bat_priv, ip_dst, hw_dst); @@ -576,10 +606,10 @@ bool batadv_dat_snoop_incoming_arp_reply(struct bat_priv *bat_priv, batadv_dbg_arp(bat_priv, skb, type, hdr_size, "Parsing incoming ARP REPLY"); - hw_src = ARP_HW_SRC(skb, hdr_size); - ip_src = ARP_IP_SRC(skb, hdr_size); - hw_dst = ARP_HW_DST(skb, hdr_size); - ip_dst = ARP_IP_DST(skb, hdr_size); + hw_src = batadv_arp_hw_src(skb, hdr_size); + ip_src = batadv_arp_ip_src(skb, hdr_size); + hw_dst = batadv_arp_hw_dst(skb, hdr_size); + ip_dst = batadv_arp_ip_dst(skb, hdr_size); /* Update our internal cache with both the IP addresses we fetched from * the ARP reply @@ -601,6 +631,7 @@ bool batadv_dat_drop_broadcast_packet(struct bat_priv *bat_priv, { struct neighbour *n; const size_t bcast_len = sizeof(struct bcast_packet); + __be32 dst_ip; /* If this packet is an ARP_REQUEST and we already have the information * that it is going to ask, we can drop the packet @@ -608,19 +639,19 @@ bool batadv_dat_drop_broadcast_packet(struct bat_priv *bat_priv, if (!forw_packet->num_packets && (ARPOP_REQUEST == batadv_arp_get_type(bat_priv, forw_packet->skb, bcast_len))) { - n = neigh_lookup(&arp_tbl, - &ARP_IP_DST(forw_packet->skb, bcast_len), + dst_ip = batadv_arp_ip_dst(forw_packet->skb, bcast_len); + n = neigh_lookup(&arp_tbl, &dst_ip, forw_packet->if_incoming->soft_iface); /* check if we already know this neigh */ if (n && (n->nud_state & NUD_CONNECTED)) { batadv_dbg(DBG_DAT, bat_priv, "ARP Request for %pI4: fallback prevented\n", - &ARP_IP_DST(forw_packet->skb, bcast_len)); + &dst_ip); return true; } batadv_dbg(DBG_DAT, bat_priv, "ARP Request for %pI4: fallback\n", - &ARP_IP_DST(forw_packet->skb, bcast_len)); + &dst_ip); } return false; } diff --git a/distributed-arp-table.h b/distributed-arp-table.h index 6b1d22c..47fe32f 100644 --- a/distributed-arp-table.h +++ b/distributed-arp-table.h @@ -29,14 +29,6 @@ #define DAT_ADDR_MAX ((dat_addr_t)~(dat_addr_t)0) -#define ARP_HW_SRC(skb, hdr_size) ((uint8_t *)(skb->data + hdr_size) + \ - ETH_HLEN + sizeof(struct arphdr)) -#define ARP_IP_SRC(skb, hdr_size) (*(__be32 *)(ARP_HW_SRC(skb, hdr_size) + \ - ETH_ALEN)) -#define ARP_HW_DST(skb, hdr_size) (ARP_HW_SRC(skb, hdr_size) + ETH_ALEN + 4) -#define ARP_IP_DST(skb, hdr_size) (*(__be32 *)(ARP_HW_SRC(skb, hdr_size) + \ - ETH_ALEN * 2 + 4)) - bool batadv_dat_snoop_outgoing_arp_request(struct bat_priv *bat_priv, struct sk_buff *skb); bool batadv_dat_snoop_incoming_arp_request(struct bat_priv *bat_priv, diff --git a/main.h b/main.h index 245323b..ea5d7d5 100644 --- a/main.h +++ b/main.h @@ -187,24 +187,37 @@ int batadv_algo_select(struct bat_priv *bat_priv, char *name); int batadv_algo_seq_print_text(struct seq_file *seq, void *offset); #ifdef CONFIG_BATMAN_ADV_DEBUG -int batadv_debug_log(struct bat_priv *bat_priv, const char *fmt, ...) -__printf(2, 3); +int batadv_debug_log(struct bat_priv *bat_priv, const char *fmt, va_list args); + +static inline void batadv_vdbg(int type, struct bat_priv *bat_priv, + const char *fmt, va_list args) +{ + if (atomic_read(&bat_priv->log_level) & type) + batadv_debug_log(bat_priv, fmt, args); +} -#define batadv_dbg(type, bat_priv, fmt, arg...) \ - do { \ - if (atomic_read(&bat_priv->log_level) & type) \ - batadv_debug_log(bat_priv, fmt, ## arg);\ - } \ - while (0) #else /* !CONFIG_BATMAN_ADV_DEBUG */ -__printf(3, 4) -static inline void batadv_dbg(int type __always_unused, - struct bat_priv *bat_priv __always_unused, - const char *fmt __always_unused, ...) + +static inline void batadv_vdbg(int type __always_unused, + struct bat_priv *bat_priv __always_unused, + const char *fmt __always_unused, + va_list args __always_unused) { } + #endif +__printf(3, 4) +static inline void batadv_dbg(int type, struct bat_priv *bat_priv, + const char *fmt, ...) +{ + va_list args; + + va_start(args, fmt); + batadv_vdbg(type, bat_priv, fmt, args); + va_end(args); +} + #define bat_info(net_dev, fmt, arg...) \ do { \ struct net_device *_netdev = (net_dev); \ -- 1.7.10

1 1

[B.A.T.M.A.N.] [PATCH] batman-adv: Mark only locally used symbol batadv_tt_local_crc as static
by Sven Eckelmann 13 May '12

13 May '12

29ccfec94d51f7725124786e29d023b212920661 changed the translation table code in such a way that it doesn't use the symbol tt_local_crc outside of translation-table.c Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- translation-table.c | 2 +- translation-table.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/translation-table.c b/translation-table.c index f50e795..62dda2b 100644 --- a/translation-table.c +++ b/translation-table.c @@ -1172,7 +1172,7 @@ static uint16_t batadv_tt_global_crc(struct bat_priv *bat_priv, } /* Calculates the checksum of the local table */ -uint16_t batadv_tt_local_crc(struct bat_priv *bat_priv) +static uint16_t batadv_tt_local_crc(struct bat_priv *bat_priv) { uint16_t total = 0, total_one; struct hashtable_t *hash = bat_priv->tt_local_hash; diff --git a/translation-table.h b/translation-table.h index 56e8016..7edc9df 100644 --- a/translation-table.h +++ b/translation-table.h @@ -41,7 +41,6 @@ void batadv_tt_global_del_orig(struct bat_priv *bat_priv, struct orig_node *batadv_transtable_search(struct bat_priv *bat_priv, const uint8_t *src, const uint8_t *addr); -uint16_t batadv_tt_local_crc(struct bat_priv *bat_priv); void batadv_tt_free(struct bat_priv *bat_priv); bool batadv_send_tt_response(struct bat_priv *bat_priv, struct tt_query_packet *tt_request); -- 1.7.10

1 0

[B.A.T.M.A.N.] Improving the roaming procedure: multiple roaming within one orig interval
by Antonio Quartulli 12 May '12

12 May '12

Hello people, as some of you may know, batman-adv has client fast-roaming support since version 2011.3.0. This technique has been introduced together with the new client announcement mechanism and it is described on its wikipage[0]. At the bottom of the same it is also written that multiple roaming of the same client within one originator interval are not supported. Right now I am working on a concept that would enable such possibility. I tried to summarise my ideas on the wiki as well[1] in order to share with you the solution I am thinking about. The document is still a draft and may not be 100% understandable. If you have time and you are curious enough to read the wiki, please drop me your feedback, it would really be appreciated :-) Thank you, [0] http://www.open-mesh.org/wiki/batman-adv/Client-roaming [1] http://www.open-mesh.org/wiki/batman-adv/MultipleRoaming -- Antonio Quartulli ..each of us alone is worth nothing.. Ernesto "Che" Guevara

2 2

[B.A.T.M.A.N.] Fwd: Batman-adv simple configuration example
by Pedro Nuno Costa Rodrigues 12 May '12

12 May '12

Hello again! First of all thank's Sven Eckelmann and Guido Iribarren for your replies and for the attention in my issue. I would like to say that i already found the solution, as you can see below. I couldn't split the radios on the wireless network, because i'm using only chips broadcom (and it isn't possible to have more than 1 radio interface). When i said that i only need a simple two router network, doesn't mean that i only going to use 2 routers... the gold is to use many of them in a mesh network, but i needed to start with a simple 2 mesh configuration router configuration. After some configuration, it worked correctly in ad-hoc mode... and to the clients access the mesh through wireless i´m going to use another router linked by cable (ethernet) using lan ports, with dd-wrt firmware (or something like that) as a AP -access point (only used to forward the signal to wireless). By cable it isn't necessary an access point, only plug the cable in batman-adv node. I'm using backfire (openwrt build): cat /home/pedro/backfire/feeds/packages/net/batman-adv/Makefile | grep 2012 # Copyright (C) 2010-2012 OpenWrt.org PKG_VERSION:=2012.0.0 BATCTL_VERSION:=2012.0.0 The batman-adv-devel version didn't work...: In the:https://dev.openwrt.org/wiki/GetSource downloaded: svn co svn://svn.openwrt.org/openwrt/trunk/ with this feed in feeds.conf.default: src-svn batman http://downloads.open-mesh.org/svn/openwrt-feed/ (i know this is a issue related with openwrt, but i must explain how i did) this is the version of the batman-adv-devel: cat /home/pedro/trunk/feeds/packages/net/batman-adv/Makefile | grep 2012 PKG_VERSION:=2012.1.0 BATCTL_VERSION:=2012.1.0 root@OpenWrt:~# batctl -v batctl 54b7d54 [batman-adv: master-b0f3829] the error was using the same configurations file (below) that worked with batman-adv backfire stable release: root@OpenWrt:/lib/batman-adv# batman-adv start /usr/sbin/batman-adv: eval: line 1: can't create/sys/class/net/bat0/mesh/orig_interval: nonexistent directory /usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/log_level: nonexistent directory /usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/bonding: nonexistent directory/usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/fragmentation: nonexistent directory /usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/gw_bandwidth: nonexistent directory /usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/gw_mode: nonexistent directory/usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/vis_mode: nonexistent directory /usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/ap_isolation: nonexistent directory I tryed to analyze if the problem was with the "crc16" lib in the configuration files, but it wasn't... the configuration files were like the backfire stable release... pedro@rodrigues:~/trunk/feeds/packages/net/batman-adv/files/lib/batman-adv$ vi config.sh #!/bin/sh bat_load_module(){ [ -d "/sys/module/batman_adv/" ] && return . /etc/functions.sh load_modules /etc/modules.d/*-crc16 /etc/modules.d/*-batman-adv*} etc.......... This is a issue to analyze... Going back to the stable release that worked fine: this is the server file of batman-adv configuration(with # comment is the client version modifications): root@OpenWrt:/etc/config# vi batman-adv config 'mesh' 'bat0' option 'interfaces' 'wifi' option 'aggregated_ogms' '1' option 'ap_isolation' '0' option 'bonding' '0' option 'fragmentation' '1' option 'gw_bandwidth' '5mbit/1024kbit' #comented line in client mode option 'gw_mode' 'server' #'client' #option 'gw_sel_class' #option 'gw_sel_class' '2' option 'log_level' 'all' option 'orig_interval' '1000' option 'vis_mode' 'server' #option 'vis_mode' 'client' ------------------------------------ this is the dhcp configuration: root@OpenWrt:/etc/config# vi dhcp config dnsmasq option domainneeded 1 option boguspriv 1 option filterwin2k 0 # enable for dial on demand option localise_queries 1 option rebind_protection 1 # disable if upstream must serve RFC1918 addresses option rebind_localhost 1 # enable for RBL checking and similar services #list rebind_domain example.lan # whitelist RFC1918 responses for domains option local '/lan/' option domain 'lan' option expandhosts 1 option nonegcache 0 option authoritative 1 option readethers 1 option leasefile '/tmp/dhcp.leases' option resolvfile '/tmp/resolv.conf.auto' #list server '/mycompany.local/1.2.3.4' #option nonwildcard 1 #list interface br-lan #list notinterface lo #list bogusnxdomain '64.94.110.11' config dhcp lan option interface lan option start 51 option limit 70 #option leasetime 12h option force 1 #this line is only for server router, the #one who is going to distribute the IP's to the clients config dhcp wan option interface wan option ignore 1 ____________________________________ this is the network file configuration: root@OpenWrt:/etc/config# vi network #### VLAN configurationconfig switch eth0 option enable 1 config switch_vlan eth0 0 option device "eth0" option vlan 0 option ports "1 2 3 4 5" config switch_vlan eth0_1 option device "eth0" option vlan 1 option ports "0 5" #### Loopback configuration config interface loopback option ifname "lo" option proto static option ipaddr 127.0.0.1 option netmask 255.0.0.0 #### LAN configuration config interface lan option type bridge option ifname "eth0.0 bat0 wlan0" option proto static option ipaddr 10.3.1.1 #10.3.1.X for other routers option netmask 255.255.255.0 option broadcast 10.3.1.255 option mtu 1500 #### WLAN configuration config interface wifi option proto none option ifname "wlan0" #option ipaddr 10.1.1.1 #option netmask 255.255.255.0 option mtu 1528 #### WAN configuration config interface wan option ifname "eth0.1" option proto dhcp ________________________________- this is the wireless file configuration: root@OpenWrt:/etc/config# vi wireless config wifi-device radio0 option type mac80211 option channel 6 option phy phy0 option hwmode 11g option country PT option txpower 20 option disabled 0 config wifi-iface option device radio0 option network wifi option mode adhoc option ssid PR option bssid XX:XX:XX:XX:XX:XX #the bssid must be the same in all routers option encryption none ______________________________________- all these configuration files are located in "/etc/config". As you can see the mesh interface is the wireless "wifi": the bat0 interface it appears only in the lan bridge; and it worked fine. root@OpenWrt:/etc/config# batctl if wlan0: active root@OpenWrt:/etc/config# batctl o [B.A.T.M.A.N. adv 2012.0.0, MainIF/MAC: wlan0/00:13:10:7c:da:73 (bat0)] Originator last-seen (#/255) Nexthop [outgoingIF]: Potential nexthops ...00:06:25:00:63:7b 0.228s (246) 00:06:25:00:63:7b [ wlan0]: 00:06:25:00:63:7b (246) root@OpenWrt:/etc/config# batctl vd dot digraph { "00:13:10:7c:da:73" -> "00:06:25:00:63:7b" [label="1.000"] "00:13:10:7c:da:73" -> "76:0f:22:e4:5f:d8" [label="TT"] subgraph "cluster_00:13:10:7c:da:73" { "00:13:10:7c:da:73" [peripheries=2] } "00:06:25:00:63:7b" -> "00:13:10:7c:da:73" [label="1.214"] "00:06:25:00:63:7b" -> "56:71:dc:31:13:2c" [label="TT"] subgraph "cluster_00:06:25:00:63:7b" { "00:06:25:00:63:7b" [peripheries=2] } } using the xdot ubuntu application it made the figure (.png) that shows the batman-adv mesh picture. The only thing that didn't start with the boot of the routers was the: -option 'gw_bandwidth' '5mbit/1024kbit' -option 'gw_mode' 'server' -option 'vis_mode' 'server' it was necessary to start manually... the rest worked weel in the boot.Just one thing before i forget... the router "server" must be the first one to start (switch on)... we must wait until it finish the boot and then we can start the client router... (the problem is probably the definition who is the master -IP distribution and so on...)(i used the "option force 1 in the dhcp configuration file, but didn't worked...) if we start the client first it will not be possible to access the internet, supposed the ISP is connected with the "server" router... the ad-hoc mode and the mesh network works the same way (works fine)... is a issue to study (yes i know that is a openwrt problem, and there are a bunch of openwrt problems here).My gold is to contribute with something here, and to get my job done as well. For now i stay here, and thank you for your lights and publications, they helped me a lot!! Best regards,Pedro Rodrigues - Portugal

3 4

Re: [B.A.T.M.A.N.] Batman-adv simple configuration example
by Pedro Nuno Costa Rodrigues 12 May '12

12 May '12

Hello again! First of all thank's Sven Eckelmann and Guido Iribarren for your replies and for the attention in my issue. I would like to say that i already found the solution, as you can see below. I couldn't split the radios on the wireless network, because i'm using only chips broadcom (and it isn't possible to have more than 1 radio interface). When i said that i only need a simple two router network, doesn't mean that i only going to use 2 routers... the gold is to use many of them in a mesh network, but i needed to start with a simple 2 mesh configuration router configuration. After some configuration, it worked correctly in ad-hoc mode... and to the clients access the mesh through wireless i´m going to use another router linked by cable (ethernet) using lan ports, with dd-wrt firmware (or something like that) as a AP -access point (only used to forward the signal to wireless). By cable it isn't necessary an access point, only plug the cable in batman-adv node. I'm using backfire (openwrt build): cat /home/pedro/backfire/feeds/packages/net/batman-adv/Makefile | grep 2012# Copyright (C) 2010-2012 OpenWrt.orgPKG_VERSION:=2012.0.0BATCTL_VERSION:=2012.0.0 The batman-adv-devel version didn't work...: In the:https://dev.openwrt.org/wiki/GetSource downloaded: svn co svn://svn.openwrt.org/openwrt/trunk/ with this feed in feeds.conf.default:src-svn batman http://downloads.open-mesh.org/svn/openwrt-feed/ (i know this is a issue related with openwrt, but i must explain how i did) this is the version of the batman-adv-devel:cat /home/pedro/trunk/feeds/packages/net/batman-adv/Makefile | grep 2012PKG_VERSION:=2012.1.0BATCTL_VERSION:=2012.1.0 root@OpenWrt:~# batctl -vbatctl 54b7d54 [batman-adv: master-b0f3829] the error was using the same configurations file (below) that worked with batman-adv backfire stable release: root@OpenWrt:/lib/batman-adv# batman-adv start/usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/orig_interval: nonexistent directory/usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/log_level: nonexistent directory/usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/bonding: nonexistent directory/usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/fragmentation: nonexistent directory/usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/gw_bandwidth: nonexistent directory/usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/gw_mode: nonexistent directory/usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/vis_mode: nonexistent directory/usr/sbin/batman-adv: eval: line 1: can't create /sys/class/net/bat0/mesh/ap_isolation: nonexistent directory I tryed to analyze if the problem was with the "crc16" lib in the configuration files, but it wasn't... the configuration files were like the backfire stable release... pedro@rodrigues:~/trunk/feeds/packages/net/batman-adv/files/lib/batman-adv$ vi config.sh #!/bin/sh bat_load_module(){ [ -d "/sys/module/batman_adv/" ] && return . /etc/functions.sh load_modules /etc/modules.d/*-crc16 /etc/modules.d/*-batman-adv*} etc.......... This is a issue to analyze... Going back to the stable release that worked fine: this is the server file of batman-adv configuration(with # comment is the client version modifications): root@OpenWrt:/etc/config# vi batman-advconfig 'mesh' 'bat0' option 'interfaces' 'wifi' option 'aggregated_ogms' '1' option 'ap_isolation' '0' option 'bonding' '0' option 'fragmentation' '1' option 'gw_bandwidth' '5mbit/1024kbit' #comented line in client mode option 'gw_mode' 'server' #'client' #option 'gw_sel_class' #option 'gw_sel_class' '2' option 'log_level' 'all' option 'orig_interval' '1000' option 'vis_mode' 'server' #option 'vis_mode' 'client' ------------------------------------ this is the dhcp configuration: root@OpenWrt:/etc/config# vi dhcpconfig dnsmasq option domainneeded 1 option boguspriv 1 option filterwin2k 0 # enable for dial on demand option localise_queries 1 option rebind_protection 1 # disable if upstream must serve RFC1918 addresses option rebind_localhost 1 # enable for RBL checking and similar services #list rebind_domain example.lan # whitelist RFC1918 responses for domains option local '/lan/' option domain 'lan' option expandhosts 1 option nonegcache 0 option authoritative 1 option readethers 1 option leasefile '/tmp/dhcp.leases' option resolvfile '/tmp/resolv.conf.auto' #list server '/mycompany.local/1.2.3.4' #option nonwildcard 1 #list interface br-lan #list notinterface lo #list bogusnxdomain '64.94.110.11' config dhcp lan option interface lan option start 51 option limit 70 #option leasetime 12h option force 1 #this line is only for server router, the #one who is going to distribute the IP's to the clients config dhcp wan option interface wan option ignore 1 ____________________________________ this is the network file configuration: root@OpenWrt:/etc/config# vi network#### VLAN configurationconfig switch eth0 option enable 1 config switch_vlan eth0_0 option device "eth0" option vlan 0 option ports "1 2 3 4 5" config switch_vlan eth0_1 option device "eth0" option vlan 1 option ports "0 5" #### Loopback configurationconfig interface loopback option ifname "lo" option proto static option ipaddr 127.0.0.1 option netmask 255.0.0.0 #### LAN configurationconfig interface lan option type bridge option ifname "eth0.0 bat0 wlan0" option proto static option ipaddr 10.3.1.1 #10.3.1.X for other routers option netmask 255.255.255.0 option broadcast 10.3.1.255 option mtu 1500 #### WLAN configurationconfig interface wifi option proto none option ifname "wlan0" #option ipaddr 10.1.1.1 #option netmask 255.255.255.0 option mtu 1528 #### WAN configuration config interface wan option ifname "eth0.1" option proto dhcp ________________________________- this is the wireless file configuration: root@OpenWrt:/etc/config# vi wirelessconfig wifi-device radio0 option type mac80211 option channel 6 option phy phy0 option hwmode 11g option country PT option txpower 20 option disabled 0 config wifi-iface option device radio0 option network wifi option mode adhoc option ssid PR option bssid XX:XX:XX:XX:XX:XX #the bssid must be the same in all routers option encryption none ______________________________________- all these configuration files are located in "/etc/config". As you can see the mesh interface is the wireless "wifi":the bat0 interface it appears only in the lan bridge;and it worked fine. root@OpenWrt:/etc/config# batctl if wlan0: active root@OpenWrt:/etc/config# batctl o [B.A.T.M.A.N. adv 2012.0.0, MainIF/MAC: wlan0/00:13:10:7c:da:73 (bat0)] Originator last-seen (#/255) Nexthop [outgoingIF]: Potential nexthops ...00:06:25:00:63:7b 0.228s (246) 00:06:25:00:63:7b [ wlan0]: 00:06:25:00:63:7b (246) root@OpenWrt:/etc/config# batctl vd dotdigraph { "00:13:10:7c:da:73" -> "00:06:25:00:63:7b" [label="1.000"] "00:13:10:7c:da:73" -> "76:0f:22:e4:5f:d8" [label="TT"] subgraph "cluster_00:13:10:7c:da:73" { "00:13:10:7c:da:73" [peripheries=2] } "00:06:25:00:63:7b" -> "00:13:10:7c:da:73" [label="1.214"] "00:06:25:00:63:7b" -> "56:71:dc:31:13:2c" [label="TT"] subgraph "cluster_00:06:25:00:63:7b" { "00:06:25:00:63:7b" [peripheries=2] }} using the xdot ubuntu application it made the figure (.png) that shows the batman-adv mesh picture. The only thing that didn't start with the boot of the routers was the:-option 'gw_bandwidth' '5mbit/1024kbit'-option 'gw_mode' 'server'-option 'vis_mode' 'server' it was necessary to start manually... the rest worked weel in the boot.Just one thing before i forget... the router "server" must be the first one to start (switch on)... we must wait until it finish the boot and then we can start the client router...(the problem is probably the definition who is the master -IP distribution and so on...)(i used the "option force 1 in the dhcp configuration file, but didn't worked...) if we start the client first it will not be possible to access the internet, supposed the ISP is connected with the "server" router... the ad-hoc mode and the mesh network works the same way (works fine)... is a issue to study (yes i know that is a openwrt problem, and there are a bunch of openwrt problems here).My gold is to contribute with something here, and to get my job done as well. For now i stay here, and thank you for your lights and publications, they helped me a lot!! Best regards,Pedro Rodrigues - Portugal

3 4

[B.A.T.M.A.N.] pull request: batman-adv 2012-05-11
by Antonio Quartulli 11 May '12

11 May '12

Hello David, this is a fixed version of the pull request issued on 2012-05-09. Comments introduced in this patchset are not following the net-tree guidelines. Another patch changing all the already existing comments will follow later. New exported functions follow the new name convention we discussed so far. A patch renaming all the existing exported functions will follow. Please let me know if there is any problem. Thank you, Antonio The following changes since commit 06a4c1c55dbe5d9f7a708e8f1a52fd2ac8e5874f: 6lowpan: IPv6 link local address (2012-05-10 23:38:22 -0400) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batman-adv-for-davem for you to fetch changes up to 35c133a000d54b7e3fe81e8c8e4b8af5878ad6dd: batman-adv: add contributor name (2012-05-11 13:56:08 +0200) ---------------------------------------------------------------- Included changes: * fix a little bug in the DHCP packet snooping introduced so far * minor fixes and cleanups * minor routing protocol API cleanups * add a new contributor name to translation-table.{c,h} * update copyright years in file headers * minor improvement for the routing algorithm ---------------------------------------------------------------- Antonio Quartulli (3): batman-adv: fix wrong dhcp option list browsing batman-adv: update copyright years batman-adv: add contributor name Linus Luessing (1): batman-adv: Adding hard_iface specific sysfs wrapper macros for UINT Marek Lindner (11): batman-adv: introduce is_single_hop_neigh variable to increase readability batman-adv: introduce packet type handler array for incoming packets batman-adv: register batman ogm receive function during protocol init batman-adv: rename last_valid to last_seen batman-adv: replace HZ calculations with jiffies_to_msecs() batman-adv: split neigh_new function into generic and batman iv specific parts batman-adv: ignore protocol packets if the interface did not enable this protocol batman-adv: refactoring API: find generalized name for bat_ogm_update_mac callback batman-adv: rename sysfs macros to reflect the soft-interface dependency batman-adv: avoid temporary routing loops by being strict on forwarded OGMs batman-adv: fix checkpatch string complaint net/batman-adv/bat_debugfs.c | 4 +- net/batman-adv/bat_iv_ogm.c | 176 +++++++++++++++++++++----------- net/batman-adv/bat_sysfs.c | 100 +++++++++++++----- net/batman-adv/bridge_loop_avoidance.c | 2 +- net/batman-adv/bridge_loop_avoidance.h | 2 +- net/batman-adv/gateway_client.c | 6 +- net/batman-adv/hard-interface.c | 117 +-------------------- net/batman-adv/main.c | 124 +++++++++++++++++++++- net/batman-adv/main.h | 6 ++ net/batman-adv/originator.c | 51 +++++---- net/batman-adv/originator.h | 7 +- net/batman-adv/packet.h | 1 + net/batman-adv/routing.c | 22 ++-- net/batman-adv/routing.h | 4 +- net/batman-adv/send.c | 2 +- net/batman-adv/translation-table.c | 2 +- net/batman-adv/translation-table.h | 2 +- net/batman-adv/types.h | 17 ++- 18 files changed, 380 insertions(+), 265 deletions(-)

3 17

[B.A.T.M.A.N.] [PATCH] batman-adv: only store changed gw_bandwidth values
by Marek Lindner 11 May '12

11 May '12

Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> --- gateway_common.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/gateway_common.c b/gateway_common.c index ca57ac7..6e3b052 100644 --- a/gateway_common.c +++ b/gateway_common.c @@ -162,6 +162,9 @@ ssize_t gw_bandwidth_set(struct net_device *net_dev, char *buff, size_t count) **/ gw_bandwidth_to_kbit((uint8_t)gw_bandwidth_tmp, &down, &up); + if (atomic_read(&bat_priv->gw_bandwidth) == gw_bandwidth_tmp) + return count; + gw_deselect(bat_priv); bat_info(net_dev, "Changing gateway bandwidth from: '%i' to: '%ld' (propagating: %d%s/%d%s)\n", -- 1.7.9.1

1 1

[B.A.T.M.A.N.] The current state of the batman-adv vis code
by Matthias Schiffer 11 May '12

11 May '12

Hi, after reading Marek's and Sven's comments to my question about the vis code, and looking at the code a bit I came to the following conclusion about the first part of the cleanup, the finishing of the RCU conversion of the vis code: It should be possible to get rid of the vis_hash_lock altogether, as the hash table has spinlocks for the hash lists itself; overall hash consistency might be a issue though - I would propose adding a hash_update function that updates a hash entry without deleting and re-adding the hlist node. I think I found a bug in the hash_add function though. First there is a RCU-locked loop that checks if a entry does already exist, but the spinlock is taken after the rcu_read_unlock() - thus allowing the same entry to be appended twice if two threads try to add it at the same time. If you want to contact me about this via IRC, I'm now idling in #batman - my nickname there is neoraider. Thanks, Matthias

3 8

[B.A.T.M.A.N.] [PATCH] batctl: add statistic retrieval component
by Marek Lindner 11 May '12

11 May '12

Signed-off-by: Marek Lindner <lindner_marek(a)yahoo.de> --- Makefile | 2 +- README | 42 ++++++++++++++ ioctl.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ ioctl.h | 23 ++++++++ main.c | 6 ++ man/batctl.8 | 19 ++++++ 6 files changed, 266 insertions(+), 1 deletions(-) create mode 100644 ioctl.c create mode 100644 ioctl.h diff --git a/Makefile b/Makefile index c85dbaa..72cecde 100755 --- a/Makefile +++ b/Makefile @@ -20,7 +20,7 @@ # batctl build BINARY_NAME = batctl -OBJ = main.o bat-hosts.o functions.o sys.o debug.o ping.o traceroute.o tcpdump.o list-batman.o hash.o vis.o debugfs.o bisect.o +OBJ = main.o bat-hosts.o functions.o sys.o debug.o ping.o traceroute.o tcpdump.o list-batman.o hash.o vis.o debugfs.o bisect.o ioctl.o MANPAGE = man/batctl.8 # batctl flags and options diff --git a/README b/README index 24dc4cf..44e1ac7 100644 --- a/README +++ b/README @@ -34,6 +34,48 @@ address to your provided host name. Host names are much easier to remember than MAC addresses. ;) +batctl statistics +================= + +The batman-adv kernel module maintains a number of traffic counters which are exported +to user space. With batctl these counters can be easily retrieved. The output may vary +depending on which features have been compiled into the kernel module. For example, if +the distributed arp table (short: dat) wasn't selected as an option at compile time +its counters won't be shown. +Each module subsystem has its own counters which are indicated by their prefixes: + * mgmt - mesh protocol counters + * tt - translation table counters + * dat - distributed arp table counters +All counters without a prefix concern payload (pure user data) traffic. + +Usage: batctl statistics + +Example: + +$ batctl statistics + tx: 14 + tx_bytes: 1316 + tx_errors: 0 + rx: 14 + rx_bytes: 1316 + forward: 0 + forward_bytes: 0 + mgmt_tx: 18 + mgmt_tx_bytes: 762 + mgmt_rx: 17 + mgmt_rx_bytes: 1020 + tt_request_tx: 0 + tt_request_rx: 0 + tt_response_tx: 0 + tt_response_rx: 0 + tt_roam_adv_tx: 0 + tt_roam_adv_rx: 0 + dat_request_tx: 0 + dat_request_rx: 0 + dat_reply_tx: 1 + dat_reply_rx: 0 + + batctl ping ============ diff --git a/ioctl.c b/ioctl.c new file mode 100644 index 0000000..92ffdb3 --- /dev/null +++ b/ioctl.c @@ -0,0 +1,175 @@ +/* + * Copyright (C) 2012 B.A.T.M.A.N. contributors: + * + * Marek Lindner <lindner_marek(a)yahoo.de> + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of version 2 of the GNU General Public + * License as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA + * 02110-1301, USA + * + */ + + +#include <stdio.h> +#include <errno.h> +#include <stdlib.h> +#include <string.h> +#include <unistd.h> +#include <sys/ioctl.h> +#include <sys/socket.h> +#include <linux/if.h> +#include <linux/sockios.h> +#include <linux/ethtool.h> + +#include "main.h" +#include "ioctl.h" +#include "debugfs.h" + +typedef unsigned long long u64; + +const char proc_net_dev_path[] = "/proc/net/dev"; + +static int statistics_common_get(char *mesh_iface) +{ + FILE *fp; + char iface[IFNAMSIZ + 1], *line_ptr = NULL;; + unsigned long long rx_bytes, rx_packets, tx_bytes, tx_packets; + unsigned long tx_errors; + size_t len = 0; + int res, ret = EXIT_FAILURE; + + rx_bytes = rx_packets = tx_bytes = tx_packets = tx_errors = 0; + + fp = fopen(proc_net_dev_path, "r"); + if (!fp) { + printf("Error - can't open '%s' for read: %s\n", + proc_net_dev_path, strerror(errno)); + goto out; + } + + while (getline(&line_ptr, &len, fp) != -1) { + res = sscanf(line_ptr, " %" STR(IFNAMSIZ) "[^: \t]: %llu %llu %*d %*d %*d %*d %*d %*d %llu %llu %lu\n", + iface, &rx_bytes, &rx_packets, &tx_bytes, &tx_packets, &tx_errors); + + if (res != 6) + continue; + + if (strcmp(iface, mesh_iface) != 0) + continue; + + printf("\t%.*s: %llu\n", ETH_GSTRING_LEN, "tx", tx_packets); + printf("\t%.*s: %llu\n", ETH_GSTRING_LEN, "tx_bytes", tx_bytes); + printf("\t%.*s: %lu\n", ETH_GSTRING_LEN, "tx_errors", tx_errors); + printf("\t%.*s: %llu\n", ETH_GSTRING_LEN, "rx", rx_packets); + printf("\t%.*s: %llu\n", ETH_GSTRING_LEN, "rx_bytes", rx_bytes); + ret = EXIT_SUCCESS; + goto out; + } + + printf("Error - interface '%s' not found\n", mesh_iface); + +out: + fclose(fp); + free(line_ptr); + return ret; +} + +/* code borrowed from ethtool */ +static int statistics_custom_get(int fd, struct ifreq *ifr) +{ + struct ethtool_drvinfo drvinfo; + struct ethtool_gstrings *strings = NULL; + struct ethtool_stats *stats = NULL; + unsigned int n_stats, sz_str, sz_stats, i; + int err, ret = EXIT_FAILURE; + + drvinfo.cmd = ETHTOOL_GDRVINFO; + ifr->ifr_data = (caddr_t)&drvinfo; + err = ioctl(fd, SIOCETHTOOL, ifr); + if (err < 0) { + printf("Error - can't open driver information: %s\n", strerror(errno)); + goto out; + } + + n_stats = drvinfo.n_stats; + if (n_stats < 1) + goto success; + + sz_str = n_stats * ETH_GSTRING_LEN; + sz_stats = n_stats * sizeof(u64); + + strings = calloc(1, sz_str + sizeof(struct ethtool_gstrings)); + stats = calloc(1, sz_stats + sizeof(struct ethtool_stats)); + if (!strings || !stats) { + printf("Error - out of memory\n"); + goto out; + } + + strings->cmd = ETHTOOL_GSTRINGS; + strings->string_set = ETH_SS_STATS; + strings->len = n_stats; + ifr->ifr_data = (caddr_t)strings; + err = ioctl(fd, SIOCETHTOOL, ifr); + if (err < 0) { + printf("Error - can't get stats strings information: %s\n", strerror(errno)); + goto out; + } + + stats->cmd = ETHTOOL_GSTATS; + stats->n_stats = n_stats; + ifr->ifr_data = (caddr_t) stats; + err = ioctl(fd, SIOCETHTOOL, ifr); + if (err < 0) { + printf("Error - can't get stats information: %s\n", strerror(errno)); + goto out; + } + + for (i = 0; i < n_stats; i++) { + printf("\t%.*s: %llu\n", ETH_GSTRING_LEN, + &strings->data[i * ETH_GSTRING_LEN], stats->data[i]); + } + +success: + ret = EXIT_SUCCESS; + +out: + free(strings); + free(stats); + return ret; +} + +int ioctl_statistics_get(char *mesh_iface) +{ + struct ifreq ifr; + int fd = -1, ret = EXIT_FAILURE; + + memset(&ifr, 0, sizeof(ifr)); + strcpy(ifr.ifr_name, mesh_iface); + + fd = socket(AF_INET, SOCK_DGRAM, 0); + if (fd < 0) { + printf("Error - can't open socket: %s\n", strerror(errno)); + goto out; + } + + ret = statistics_common_get(mesh_iface); + if (ret != EXIT_SUCCESS) + goto out; + + ret = statistics_custom_get(fd, &ifr); + +out: + if (fd >= 0) + close(fd); + return ret; +} diff --git a/ioctl.h b/ioctl.h new file mode 100644 index 0000000..0a6a7d6 --- /dev/null +++ b/ioctl.h @@ -0,0 +1,23 @@ +/* + * Copyright (C) 2012 B.A.T.M.A.N. contributors: + * + * Marek Lindner <lindner_marek(a)yahoo.de> + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of version 2 of the GNU General Public + * License as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA + * 02110-1301, USA + * + */ + + +int ioctl_statistics_get(char *mesh_iface); diff --git a/main.c b/main.c index 86e2078..1c3af02 100644 --- a/main.c +++ b/main.c @@ -36,6 +36,7 @@ #include "tcpdump.h" #include "bisect.h" #include "vis.h" +#include "ioctl.h" #include "functions.h" #include <err.h> @@ -63,6 +64,7 @@ void print_usage(void) { printf(" \tfragmentation|f [0|1] \tdisplay or modify the fragmentation mode setting\n"); printf(" \tap_isolation|ap [0|1] \tdisplay or modify the ap isolation mode setting\n"); printf("\n"); + printf(" \tstatistics|stat \tprint mesh statistics\n"); printf(" \tping|p <destination> \tping another batman adv host via layer 2\n"); printf(" \ttraceroute|tr <destination> \ttraceroute another batman adv host via layer 2\n"); printf(" \ttcpdump|td <interface> \ttcpdump layer 2 traffic on the given interface\n"); @@ -213,6 +215,10 @@ int main(int argc, char **argv) ret = handle_sys_setting(mesh_iface, argc - 1, argv + 1, SYS_AP_ISOLA, ap_isolation_usage, sysfs_param_enable); + } else if ((strcmp(argv[1], "statistics") == 0) || (strcmp(argv[1], "stat") == 0)) { + + ret = ioctl_statistics_get(mesh_iface); + } else if ((strcmp(argv[1], "bisect") == 0)) { ret = bisect(argc - 1, argv + 1); diff --git a/man/batctl.8 b/man/batctl.8 index 7b159d0..a37b718 100644 --- a/man/batctl.8 +++ b/man/batctl.8 @@ -158,6 +158,25 @@ If no parameter is given the current fragmentation mode setting is displayed. Ot .IP "\fBap_isolation\fP|\fBap\fP [\fB1\fP|\fB0\fP]" If no parameter is given the current ap isolation setting is displayed. Otherwise the parameter is used to enable or disable ap isolation. .br +.IP "\fBstatistics\fP|\fBstat\fP" +Retrieve traffic counters from batman-adv kernel module. The output may vary depending on which features have +been compiled into the kernel module. For example, if the distributed arp table (short: dat) wasn't selected +as an option at compile time its counters won't be shown. +.br +Each module subsystem has its own counters which are indicated by their prefixes: +.RS 15 +mgmt - mesh protocol counters +.RE +.RS 17 +tt - translation table counters +.RE +.RS 16 +dat - distributed arp table counters +.RE +.RS 7 +All counters without a prefix concern payload (pure user data) traffic. +.RE +.br .IP "\fBping\fP|\fBp\fP [\fB\-c count\fP][\fB\-i interval\fP][\fB\-t time\fP][\fB\-R\fP] \fBMAC_address\fP|\fBbat\-host_name\fP" Layer 2 ping of a MAC address or bat\-host name. batctl will try to find the bat\-host name if the given parameter was not a MAC -- 1.7.9.1

1 1

[B.A.T.M.A.N.] [PATCH] batman-adv: use DBG_ALL in log_level sysfs definition
by Antonio Quartulli 11 May '12

11 May '12

Each time a new log level is added the developer must change either the DBG_ALL enum definition and the hard coded value in the bat_sysfs.c for the log_level attribute max value. This is extremely error prone. With this patch the code directly uses DBG_ALL in the sysfs definition Signed-off-by: Antonio Quartulli <ordex(a)autistici.org> --- bat_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bat_sysfs.c b/bat_sysfs.c index 6ba3d89..dc1edbe 100644 --- a/bat_sysfs.c +++ b/bat_sysfs.c @@ -445,7 +445,7 @@ BAT_ATTR_SIF_UINT(gw_sel_class, S_IRUGO | S_IWUSR, 1, TQ_MAX_VALUE, static BAT_ATTR(gw_bandwidth, S_IRUGO | S_IWUSR, show_gw_bwidth, store_gw_bwidth); #ifdef CONFIG_BATMAN_ADV_DEBUG -BAT_ATTR_SIF_UINT(log_level, S_IRUGO | S_IWUSR, 0, 31, NULL); +BAT_ATTR_SIF_UINT(log_level, S_IRUGO | S_IWUSR, 0, DBG_ALL, NULL); #endif static struct bat_attribute *mesh_attrs[] = { -- 1.7.9.4

2 1

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N