B.A.T.M.A.N

b.a.t.m.a.n@lists.open-mesh.org

15 participants
4308 discussions

[B.A.T.M.A.N.] use_count = 1 / device stuck on reboot or netifd restart
by Ufo 25 Feb '15

25 Feb '15

in leipzig since months we have problems with batman-adv and these start/stop scripts or netifd-stuff. we thought that this might be our own special problem, because we are using more than one batman-adv instance (separated by vlan). but its still there, also on openwrt-cc-trunk, now also on our batman-adv super-gluon-node-servers (using fastd) on virtualized x86-openwrt. so f.i. i can crash that system in a way by: etc/init.d/fastd stop please help us and have a look at our local ticket number 23 https://github.com/freifunk/firmware-leipzig/issues/23 good luck ufo root@vpnb9:~# batctl -v batctl 2014.4.0 [batman-adv: 2014.4.0] root@vpnb9:~# fastd -v fastd v17 root@vpnb9:~# cat /etc/openwrt_* DISTRIB_ID='OpenWrt' DISTRIB_RELEASE='Bleeding Edge' DISTRIB_REVISION='r44497' DISTRIB_CODENAME='chaos_calmer' DISTRIB_TARGET='x86/kvm_guest' DISTRIB_DESCRIPTION='OpenWrt Chaos Calmer r44497' DISTRIB_TAINTS='' r44497 -- --- Freifunk Leipzig http://leipzig.freifunk.net

2 1

[B.A.T.M.A.N.] [PATCH] batman-adv: Remove uses of return value of seq_printf
by Joe Perches 22 Feb '15

22 Feb '15

This function is soon going to return void so remove the return value use. Convert the return value to test seq_has_overflowed() instead. Signed-off-by: Joe Perches <joe(a)perches.com> --- net/batman-adv/gateway_client.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c index 27649e8..a0876ea 100644 --- a/net/batman-adv/gateway_client.c +++ b/net/batman-adv/gateway_client.c @@ -592,15 +592,16 @@ static int batadv_write_buffer_text(struct batadv_priv *bat_priv, curr_gw = batadv_gw_get_selected_gw_node(bat_priv); - ret = seq_printf(seq, "%s %pM (%3i) %pM [%10s]: %u.%u/%u.%u MBit\n", - (curr_gw == gw_node ? "=>" : " "), - gw_node->orig_node->orig, - router_ifinfo->bat_iv.tq_avg, router->addr, - router->if_incoming->net_dev->name, - gw_node->bandwidth_down / 10, - gw_node->bandwidth_down % 10, - gw_node->bandwidth_up / 10, - gw_node->bandwidth_up % 10); + seq_printf(seq, "%s %pM (%3i) %pM [%10s]: %u.%u/%u.%u MBit\n", + (curr_gw == gw_node ? "=>" : " "), + gw_node->orig_node->orig, + router_ifinfo->bat_iv.tq_avg, router->addr, + router->if_incoming->net_dev->name, + gw_node->bandwidth_down / 10, + gw_node->bandwidth_down % 10, + gw_node->bandwidth_up / 10, + gw_node->bandwidth_up % 10); + ret = seq_has_overflowed(seq); if (curr_gw) batadv_gw_node_free_ref(curr_gw);

3 4

[B.A.T.M.A.N.] checkpatch: CHECK: No space is necessary after a cast
by Marek Lindner 20 Feb '15

20 Feb '15

Hi Joe, we have come across a checkpatch false-positive: >>>> static void batadv_recv_handler_init(void) { int i; for (i = 0; i < ARRAY_SIZE(batadv_rx_handler); i++) batadv_rx_handler[i] = batadv_recv_unhandled_packet; for (i = BATADV_UNICAST_MIN; i <= BATADV_UNICAST_MAX; i++) batadv_rx_handler[i] = batadv_recv_unhandled_unicast_packet; /* compile time checks for sizes */ BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6); BUILD_BUG_ON(sizeof(struct batadv_ogm_packet) != 24); BUILD_BUG_ON(sizeof(struct batadv_icmp_header) != 20); .. } <<<<< The following warnings are triggered: CHECK: No space is necessary after a cast #440: FILE: main.c:440: + BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6); CHECK: No space is necessary after a cast #441: FILE: main.c:441: + BUILD_BUG_ON(sizeof(struct batadv_ogm_packet) != 24); CHECK: No space is necessary after a cast #442: FILE: main.c:442: + BUILD_BUG_ON(sizeof(struct batadv_icmp_header) != 20); Can you make a suggestion / patch for checkpatch to better handle this case ? Thanks, Marek

2 3

[B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch - wrong alignment
by Marek Lindner 20 Feb '15

20 Feb '15

Introduced by fe67bb41f0e1647c3b05aeb4b736a1171bff496b ("batman-adv: debugfs, avoid compiling for !DEBUG_FS") Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch> --- debugfs.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/debugfs.h b/debugfs.h index 5db336a..421f092 100644 --- a/debugfs.h +++ b/debugfs.h @@ -48,14 +48,14 @@ static inline void batadv_debugfs_del_meshif(struct net_device *dev) { } -static inline int batadv_debugfs_add_hardif( - struct batadv_hard_iface *hard_iface) +static inline +int batadv_debugfs_add_hardif(struct batadv_hard_iface *hard_iface) { return 0; } -static inline void batadv_debugfs_del_hardif( - struct batadv_hard_iface *hard_iface) +static inline +void batadv_debugfs_del_hardif(struct batadv_hard_iface *hard_iface) { } -- 2.1.4

1 1

[B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch - spaces preferred around that '*'
by Marek Lindner 19 Feb '15

19 Feb '15

Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch> --- main.h | 2 +- network-coding.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/main.h b/main.h index 515bf5a..b6c9ece 100644 --- a/main.h +++ b/main.h @@ -44,7 +44,7 @@ #define BATADV_TT_CLIENT_TEMP_TIMEOUT 600000 /* in milliseconds */ #define BATADV_TT_WORK_PERIOD 5000 /* 5 seconds */ #define BATADV_ORIG_WORK_PERIOD 1000 /* 1 second */ -#define BATADV_DAT_ENTRY_TIMEOUT (5*60000) /* 5 mins in milliseconds */ +#define BATADV_DAT_ENTRY_TIMEOUT (5 * 60000) /* 5 mins in milliseconds */ /* sliding packet range of received originator messages in sequence numbers * (should be a multiple of our word size) */ diff --git a/network-coding.c b/network-coding.c index 127cc4d..ec6d6e5 100644 --- a/network-coding.c +++ b/network-coding.c @@ -275,7 +275,7 @@ static bool batadv_nc_to_purge_nc_path_decoding(struct batadv_priv *bat_priv, * max_buffer time */ return batadv_has_timed_out(nc_path->last_valid, - bat_priv->nc.max_buffer_time*10); + bat_priv->nc.max_buffer_time * 10); } /** -- 2.1.4

1 1

[B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch - comparison to NULL could be rewritten
by Marek Lindner 19 Feb '15

19 Feb '15

Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch> --- soft-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/soft-interface.c b/soft-interface.c index 8748987..d41746b 100644 --- a/soft-interface.c +++ b/soft-interface.c @@ -824,7 +824,7 @@ static int batadv_softif_slave_add(struct net_device *dev, int ret = -EINVAL; hard_iface = batadv_hardif_get_by_netdev(slave_dev); - if (!hard_iface || hard_iface->soft_iface != NULL) + if (!hard_iface || hard_iface->soft_iface) goto out; ret = batadv_hardif_enable_interface(hard_iface, dev->name); -- 2.1.4

1 1

[B.A.T.M.A.N.] [PATCHv2] batman-adv: Use safer default config for optional features
by Sven Eckelmann 19 Feb '15

19 Feb '15

The current default settings for optional features in batman-adv seems to be based around the idea that the user only compiles what he requires. They will automatically enabled when they are compiled in. For example the network coding part of batman-adv is by default disabled in the out-of-tree module but will be enabled when the code is compiled during the module build. But distributions like Debian just enable all features of the batman-adv kernel module and hope that more experimental features or features with possible negative effects have to be enabled using some runtime configuration interface. The network_coding feature can help in specific setups but also has drawbacks and is not disabled by default in the out-of-tree module. Disabling by default in the runtime config seems to be also quite sane. The bridge_loop_avoidance is the only feature which is disabled by default but may be necessary even in simple setups. Packet loops may even be created during the initial node setup when this is not enabled. This is different than STP on bridges because mesh is usually used on Adhoc WiFi. Having two nodes (by accident) in the same LAN segment and in the same mesh network is rather common in this situation. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- DAT is now removed from this patch because the discussion showed that it is preferred to have DAT enabled by default. network-coding.c | 2 +- soft-interface.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/network-coding.c b/network-coding.c index 127cc4d..be005b2 100644 --- a/network-coding.c +++ b/network-coding.c @@ -155,7 +155,7 @@ err: */ void batadv_nc_init_bat_priv(struct batadv_priv *bat_priv) { - atomic_set(&bat_priv->network_coding, 1); + atomic_set(&bat_priv->network_coding, 0); bat_priv->nc.min_tq = 200; bat_priv->nc.max_fwd_delay = 10; bat_priv->nc.max_buffer_time = 200; diff --git a/soft-interface.c b/soft-interface.c index 8748987..22254fb 100644 --- a/soft-interface.c +++ b/soft-interface.c @@ -738,7 +738,7 @@ static int batadv_softif_init_late(struct net_device *dev) atomic_set(&bat_priv->aggregated_ogms, 1); atomic_set(&bat_priv->bonding, 0); #ifdef CONFIG_BATMAN_ADV_BLA - atomic_set(&bat_priv->bridge_loop_avoidance, 0); + atomic_set(&bat_priv->bridge_loop_avoidance, 1); #endif #ifdef CONFIG_BATMAN_ADV_DAT atomic_set(&bat_priv->distributed_arp_table, 1); -- 2.1.4

3 2

[B.A.T.M.A.N.] Question concerning batman-adv bug #173 "Mesh packets on bat0"
by Andreas Pape 19 Feb '15

19 Feb '15

Hello everybody, I'm interested if there is any progress concerning the bug entry #173 ( http://www.open-mesh.org/issues/173). I'm currently observing something similiar on an embedded system running an older kernel 2.6.32.26. Batman-adv versions up to 2013.1.0 work flawlessly out of the box. All newer versions show the phenomenon described in bug #173. In my case I found out, that the batadv_batman_skb_recv function is never called again as soon as I add bat0 to the bridge interface I use. If I use the bat0 interface outside a bridge, everything works fine up to the latest version I tested (which was 2014.4.0) even with the old kernel version. Regards, Andreas Pape

2 12

[B.A.T.M.A.N.] [PATCH] batman-adv: Use safer default config for optional features
by Sven Eckelmann 18 Feb '15

18 Feb '15

The current default settings for optional features in batman-adv seems to be based around the idea that the user only compiles what he requires. They will automatically enabled when they are compiled in. For example the network coding part of batman-adv is by default disabled in the out-of-tree module but will be enabled when the code is compiled during the module build. But distributions like Debian just enable all features of the batman-adv kernel module and hope that more experimental features or features with possible negative effects have to be enabled using some runtime configuration interface. The network_coding feature can help in specific setups but also has drawbacks and is not disabled by default in the out-of-tree module. Disabling by default in the runtime config seems to be also quite sane. The distributed_arp_table is in theory a good solution to reduce connection problems in large networks caused by ARP packet loss. Unfortunatelly, it seems to also break ARP resolution in simple mesh setups. The only solution which seems to be used by AP firmwares seems to be the deactivation of this feature. Disabling this feature by default until the problem was understood and fixed may help new deployments to create a working mesh. Tuning of the mesh can still be done by them in case DAT works in their setup. The bridge_loop_avoidance is the only feature which is disabled by default but may be necessary even in simple setups. Packet loops may even be created during the initial node setup when this is not enabled. This is different than STP on bridges because mesh is usually used on Adhoc WiFi. Having two nodes (by accident) in the same LAN segment and in the same mesh network is rather common in this situation. Signed-off-by: Sven Eckelmann <sven(a)narfation.org> -- This patchset is based on my comments in https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2014-November/012543.html The patch doesn't touch the multicast feature because I have no idea how well it works and what the current multicast mode is actual doing. --- network-coding.c | 2 +- soft-interface.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/network-coding.c b/network-coding.c index 127cc4d..be005b2 100644 --- a/network-coding.c +++ b/network-coding.c @@ -155,7 +155,7 @@ err: */ void batadv_nc_init_bat_priv(struct batadv_priv *bat_priv) { - atomic_set(&bat_priv->network_coding, 1); + atomic_set(&bat_priv->network_coding, 0); bat_priv->nc.min_tq = 200; bat_priv->nc.max_fwd_delay = 10; bat_priv->nc.max_buffer_time = 200; diff --git a/soft-interface.c b/soft-interface.c index 8748987..ae96cee 100644 --- a/soft-interface.c +++ b/soft-interface.c @@ -738,10 +738,10 @@ static int batadv_softif_init_late(struct net_device *dev) atomic_set(&bat_priv->aggregated_ogms, 1); atomic_set(&bat_priv->bonding, 0); #ifdef CONFIG_BATMAN_ADV_BLA - atomic_set(&bat_priv->bridge_loop_avoidance, 0); + atomic_set(&bat_priv->bridge_loop_avoidance, 1); #endif #ifdef CONFIG_BATMAN_ADV_DAT - atomic_set(&bat_priv->distributed_arp_table, 1); + atomic_set(&bat_priv->distributed_arp_table, 0); #endif #ifdef CONFIG_BATMAN_ADV_MCAST bat_priv->mcast.flags = BATADV_NO_FLAGS; -- 2.1.4

4 7

[B.A.T.M.A.N.] Understanding MAC-Adresses in iptables-Logs
by Jan Lühr 18 Feb '15

18 Feb '15

Hello folks, there appears to be some misconfiguration in our network. A gateway is blocking unknown ip-addresses: [658047.514011] FORWARD DROPPEDIN=bat0 OUT=backbone MAC=3a:81:5b:64:fa:32:08:fc:88:9b:8a:60:08:00:45:00:00:4f:6c:b1:40:00:3f:06:b8:8e:0a:a6 SRC=10.166.28.69 DST=173.194.65.188 LEN=79 TOS=0x00 PREC=0x00 TTL=63 ID=27825 DF PROTO=TCP SPT=45173 DPT=5228 WINDOW=9131 RES=0x00 ACK PSH URGP=0 [658047.519455] FORWARD DROPPEDIN=bat0 OUT=backbone MAC=3a:81:5b:64:fa:32:08:fc:88:9b:8a:60:08:00:45:00:00:34:6c:b2:40:00:3f:06:b8:a8:0a:a6 SRC=10.166.28.69 DST=173.194.65.188 LEN=52 TOS=0x00 PREC=0x00 TTL=63 ID=27826 DF PROTO=TCP SPT=45173 DPT=5228 WINDOW=9131 RES=0x00 ACK FIN URGP=0 I'm somewhat confused by the mac-address here - it's very long. Can I somehow derive, which originator or client is propagating or using this address? Greetz, Jan

2 1

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N