B.A.T.M.A.N

b.a.t.m.a.n@lists.open-mesh.org

14 participants
4306 discussions

Re: Yocto meta-batman
by Sven Eckelmann 11 Jul '23

11 Jul '23

On Tuesday, 11 July 2023 15:03:25 CEST anders.berndtsson(a)idptech.se wrote: > Is there anyone supporting Yocto layer meta-batman ? > > https://github.com/jhaws1982/meta-batman Why aren't you asking the maintainer [1]? But he already wrote [2] on the mailinglist [3] that he will only accept PRs but not maintain it actively. Kind regards, Sven [1] https://github.com/jhaws1982/meta-batman#patches [2] https://lore.kernel.org/batman/DFCF0D4B-8A76-4CB8-9577-620452E7F116@sdl.usu… [3] https://www.open-mesh.org/projects/open-mesh/wiki/MailingList

1 0

forwarding works fine with 802.1ad vlans
by pony 04 Jul '23

04 Jul '23

Hello, In https://www.open-mesh.org/projects/batman-adv/wiki/Faq#VLAN-forwarding-does… it is stated that batman advanced will only forward vlan frames when it knows about the vlan. However this seems only to be true for 802.1q vlans. I was able to send 802.1ad tagged frames over the mesh without configuring any vlans on top of the soft interface. I am using batman-adv 2022.0-openwrt-6. When I try the same with 802.1q it behaves as described in the wiki page. This may be be problematic when people rely on batman advanced not forwarding vlan tagged frames. Kind regards, pony

2 1

Authenticity of routing information in Batman
by Marek Küthe 03 Jul '23

03 Jul '23

Hello, I recently came across Batman Adv and the question arose in my mind whether it is possible to authenticate the routing information exchange - for example with HMAC as in babel. This would for example prevent attacks where a malicious node says "I have the perfect route to the destination!". I am not concerned with encryption or authentication of the traffic, only of the routing information. Is there anything like this in Batman (Adv)? If not, is it planned to implement something like this? If there isn't, does anyone have an idea how something like this could be done differently (in a different layer)? I would be very happy to receive answers! Greetings Marek Küthe -- Marek Küthe m.k(a)mk16.de er/ihm he/him

2 1

[PATCH] alfred: receive data with valid source on unix sock without active interface
by Marek Lindner 03 Jul '23

03 Jul '23

Signed-off-by: Marek Lindner <mareklindner(a)neomailbox.ch> --- unix_sock.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/unix_sock.c b/unix_sock.c index ce08a51..e6208ef 100644 --- a/unix_sock.c +++ b/unix_sock.c @@ -108,10 +108,6 @@ static int unix_sock_add_data(struct globals *globals, int len, data_len, ret = -1; struct interface *interface; - interface = netsock_first_interface(globals); - if (!interface) - goto err; - len = ntohs(push->header.length); if (len < (int)(sizeof(*push) - sizeof(push->header))) @@ -133,11 +129,26 @@ static int unix_sock_add_data(struct globals *globals, * source addresses. Otherwise the data would not be * synced between primary servers. */ - if (is_valid_ether_addr(data->source)) { + if (is_iface_disabled(globals->net_iface)) { + if (!is_valid_ether_addr(data->source)) + goto err; + + if (globals->opmode != OPMODE_PRIMARY) + goto err; + + } else if (is_valid_ether_addr(data->source)) { + interface = netsock_first_interface(globals); + if (!interface) + goto err; + if (memcmp(data->source, &interface->hwaddr, ETH_ALEN) != 0 && globals->opmode != OPMODE_PRIMARY) goto err; } else { + interface = netsock_first_interface(globals); + if (!interface) + goto err; + memcpy(data->source, &interface->hwaddr, ETH_ALEN); } -- 2.38.1

1 0

Error - mac address of the ping destination could not be resolved and is not a bat-host name
by mark.mundy＠draeger.com 29 Jun '23

29 Jun '23

What is the best way to figure out why 2 nodes that are connected on a WMN can see each other through 'batctl n', but 'batman ping' fails with the message "Error - mac address of the ping destination could not be resolved and is not a bat-host name"? Node at eth1 - 10.1.1.1, wlan0 mac ether 04:f0:21:59:38:c9 root@jammy-newport:~# batctl n [B.A.T.M.A.N. adv 2021.3, MainIF/MAC: wlan0/04:f0:21:59:38:c9 (bat0/72:85:90:2a:95:06 BATMAN_IV)] IF Neighbor last-seen wlan0 c4:4b:d1:90:02:90 0.500s root@jammy-newport:~# batctl ping 10.2.1.1 Error - mac address of the ping destination could not be resolved and is not a bat-host name: 10.2.1.1 Node at eth1 - 10.2.1.1, wlan0 mac ether c4:4b:d1:90:02:90 root@focal-newport:~# batctl n [B.A.T.M.A.N. adv 2021.3, MainIF/MAC: wlan0/c4:4b:d1:90:02:90 (bat0/6e:87:15:7e:f3:14 BATMAN_IV)] IF Neighbor last-seen wlan0 04:f0:21:59:38:c9 0.708s root@focal-newport:~# batctl ping 10.1.1.1 Error - mac address of the ping destination could not be resolved and is not a bat-host name: 10.1.1.1 My intention is to be able to reach a computer on the far side of the WMN connected to eth1 10.2.1.1 from my host computer connected to the same network on eth1 10.1.1.1. It should look something like this. network -> eth1 10.1.1.1 -> wlan0 -> bat0 (inet 10.1.1.4) -> BATMAN -> bat0 (inet 10.2.1.4) -> wlan0 -> eth1 10.2.1.1 -> non-BATMAN computer My intention is to have eth1 10.1.1.1 connected to the main network as an interface for bat0 able to communicate over bat0. On the other end, eth1 10.2.1.1 The interfaces for eth1 and wlan0 show as active for both computers. For completeness, I'm working in Ubuntu 20.04 /etc/network/interfaces for 10.1.1.1 source-directory /etc/network/interfaces.d allow-hotplug eth0 auto eth0 iface eth0 inet dhcp allow hotplug eth1 auto eth1 iface eth1 inet static address 10.1.1.1 netmask 255.0.0.0 gateway 10.0.0.1 # dns-nameservers 1.1.1.1 8.8.8.8 8.8.4.4 allow hotplug bat0 auto bat0 iface bat0 inet static address 10.1.1.4 netmask 255.0.0.0 up ip link set up dev $IFACE pre-up ip link set up dev wlan0 pre-up iw dev wlan0 del pre-up iw phy phy0 interface add wlan0 type mesh pre-up iw dev wlan0 set channel 149 80MHz pre-up ip link set up dev wlan0 pre-up iw dev wlan0 mesh join mesh149 pre-up batctl if add wlan0 pre-up batctl if add eth1 down ip link set down dev $IFACE batman-adv-bridge yes batman-adv-mesh-id bat0 batman-adv-multicast-mode 1 batman-adv-ttl 50 batman-adv-originator-ttl 50 batman-adv-gateway-mode server batman-adv-hard-interface wlan0 batman-adv-hard-interface eth1 ifconfig output: bat0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500 inet 10.1.1.4 netmask 255.0.0.0 broadcast 10.255.255.255 inet6 fe80::7085:90ff:fe2a:9506 prefixlen 64 scopeid 0x20<link> ether 72:85:90:2a:95:06 txqueuelen 1000 (Ethernet) RX packets 299 bytes 12606 (12.6 KB) RX errors 0 dropped 0 overruns 0 frame 0 TX packets 1 bytes 90 (90.0 B) TX errors 0 dropped 14 overruns 0 carrier 0 collisions 0 eth0: flags=4099<UP,BROADCAST,MULTICAST> mtu 1500 ether 00:d0:12:21:f7:d6 txqueuelen 1000 (Ethernet) RX packets 0 bytes 0 (0.0 B) RX errors 0 dropped 0 overruns 0 frame 0 TX packets 0 bytes 0 (0.0 B) TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0 eth1: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500 inet 10.1.1.1 netmask 255.0.0.0 broadcast 10.255.255.255 inet6 fe80::2d0:12ff:fe21:f7d7 prefixlen 64 scopeid 0x20<link> ether 00:d0:12:21:f7:d7 txqueuelen 1000 (Ethernet) RX packets 4556 bytes 328215 (328.2 KB) RX errors 0 dropped 0 overruns 0 frame 0 TX packets 7817 bytes 486324 (486.3 KB) TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0 lo: flags=73<UP,LOOPBACK,RUNNING> mtu 65536 inet 127.0.0.1 netmask 255.0.0.0 inet6 ::1 prefixlen 128 scopeid 0x10<host> loop txqueuelen 1000 (Local Loopback) RX packets 25 bytes 1425 (1.4 KB) RX errors 0 dropped 0 overruns 0 frame 0 TX packets 25 bytes 1425 (1.4 KB) TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0 wlan0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500 inet6 fe80::6f0:21ff:fe59:38c9 prefixlen 64 scopeid 0x20<link> ether 04:f0:21:59:38:c9 txqueuelen 1000 (Ethernet) RX packets 5822 bytes 353632 (353.6 KB) RX errors 0 dropped 0 overruns 0 frame 0 TX packets 6119 bytes 532058 (532.0 KB) TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0 /etc/network/interfaces for 10.2.1.1 source-directory /etc/network/interfaces.d allow-hotplug eth0 auto eth0 iface eth0 inet dhcp allow hotplug eth1 auto eth1 iface eth1 inet static address 10.2.1.1 netmask 255.0.0.0 gateway 10.0.0.1 # dns-nameservers 1.1.1.1 8.8.8.8 8.8.4.4 allow hotplug bat0 auto bat0 iface bat0 inet static address 10.2.1.4 netmask 255.0.0.0 up ip link set up dev $IFACE pre-up ip link set up dev wlan0 pre-up iw dev wlan0 del pre-up iw phy phy0 interface add wlan0 type mesh pre-up iw dev wlan0 set channel 149 80MHz pre-up ip link set up dev wlan0 pre-up iw dev wlan0 mesh join mesh149 pre-up batctl if add wlan0 pre-up batctl if add eth1 down ip link set down dev $IFACE batman-adv-bridge yes batman-adv-mesh-id bat0 batman-adv-multicast-mode 1 batman-adv-ttl 50 batman-adv-originator-ttl 50 batman-adv-gateway-mode server batman-adv-hard-interface wlan0 batman-adv-hard-interface eth1 ifconfig output: bat0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500 inet 10.2.1.4 netmask 255.0.0.0 broadcast 10.255.255.255 inet6 fe80::6c87:15ff:fe7e:f314 prefixlen 64 scopeid 0x20<link> ether 6e:87:15:7e:f3:14 txqueuelen 1000 (Ethernet) RX packets 42 bytes 1764 (1.7 KB) RX errors 0 dropped 5 overruns 0 frame 0 TX packets 2 bytes 180 (180.0 B) TX errors 0 dropped 19 overruns 0 carrier 0 collisions 0 eth0: flags=4099<UP,BROADCAST,MULTICAST> mtu 1500 ether 00:d0:12:93:f7:83 txqueuelen 1000 (Ethernet) RX packets 0 bytes 0 (0.0 B) RX errors 0 dropped 0 overruns 0 frame 0 TX packets 0 bytes 0 (0.0 B) TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0 eth1: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500 inet 10.2.1.1 netmask 255.0.0.0 broadcast 10.255.255.255 inet6 fe80::2d0:12ff:fe93:f784 prefixlen 64 scopeid 0x20<link> ether 00:d0:12:93:f7:84 txqueuelen 1000 (Ethernet) RX packets 74 bytes 4826 (4.8 KB) RX errors 0 dropped 0 overruns 0 frame 0 TX packets 796 bytes 49010 (49.0 KB) TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0 lo: flags=73<UP,LOOPBACK,RUNNING> mtu 65536 inet 127.0.0.1 netmask 255.0.0.0 inet6 ::1 prefixlen 128 scopeid 0x10<host> loop txqueuelen 1000 (Local Loopback) RX packets 354 bytes 27080 (27.0 KB) RX errors 0 dropped 0 overruns 0 frame 0 TX packets 354 bytes 27080 (27.0 KB) TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0 wlan0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500 inet6 fe80::c64b:d1ff:fe90:290 prefixlen 64 scopeid 0x20<link> ether c4:4b:d1:90:02:90 txqueuelen 1000 (Ethernet) RX packets 508 bytes 33612 (33.6 KB) RX errors 0 dropped 0 overruns 0 frame 0 TX packets 528 bytes 48806 (48.8 KB) TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0

3 4

[syzbot] [batman?] WARNING in batadv_dat_free (2)
by syzbot 21 Jun '23

21 Jun '23

Hello, syzbot found the following issue on: HEAD commit: 970308a7b544 selftests/bpf: Set the default value of consu.. git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=1788094b280000 kernel config: https://syzkaller.appspot.com/x/.config?x=ba5f40cc4484255a dashboard link: https://syzkaller.appspot.com/bug?extid=6c881e6772625dc7feed compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 Unfortunately, I don't have any reproducer for this issue yet. Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/fc4c2bba1144/disk-970308a7.raw… vmlinux: https://storage.googleapis.com/syzbot-assets/1075dd8a55dc/vmlinux-970308a7.… kernel image: https://storage.googleapis.com/syzbot-assets/59f3fdc83b37/bzImage-970308a7.… IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+6c881e6772625dc7feed(a)syzkaller.appspotmail.com bond0 (unregistering): (slave bond_slave_1): Releasing backup interface bond0 (unregistering): (slave bond_slave_0): Releasing backup interface bond0 (unregistering): Released all slaves ------------[ cut here ]------------ WARNING: CPU: 1 PID: 1005 at kernel/workqueue.c:642 set_work_data kernel/workqueue.c:642 [inline] WARNING: CPU: 1 PID: 1005 at kernel/workqueue.c:642 clear_work_data kernel/workqueue.c:705 [inline] WARNING: CPU: 1 PID: 1005 at kernel/workqueue.c:642 __cancel_work_timer+0x4d1/0x570 kernel/workqueue.c:3278 Modules linked in: CPU: 1 PID: 1005 Comm: kworker/u4:5 Not tainted 6.4.0-rc3-syzkaller-00722-g970308a7b544 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023 Workqueue: netns cleanup_net RIP: 0010:set_work_data kernel/workqueue.c:642 [inline] RIP: 0010:clear_work_data kernel/workqueue.c:705 [inline] RIP: 0010:__cancel_work_timer+0x4d1/0x570 kernel/workqueue.c:3278 Code: e8 34 08 0e 00 e9 e1 fb ff ff e8 2a 41 30 00 e8 55 f5 bb 08 e9 51 fd ff ff e8 1b 41 30 00 0f 0b e9 a6 fc ff ff e8 0f 41 30 00 <0f> 0b e9 c0 fd ff ff e8 b3 4e 83 00 e9 fd fe ff ff e8 f9 40 30 00 RSP: 0018:ffffc90005237920 EFLAGS: 00010293 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: ffff88802076d940 RSI: ffffffff815401c1 RDI: 0000000000000001 RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: ffff888019b654b0 R13: 1ffff92000a46f25 R14: 0000000000000001 R15: ffff88802076d940 FS: 0000000000000000(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f31ad4beba8 CR3: 000000002a10a000 CR4: 00000000003506e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000600 Call Trace: <TASK> batadv_dat_free+0x45/0xe0 net/batman-adv/distributed-arp-table.c:840 batadv_mesh_free+0x89/0x170 net/batman-adv/main.c:270 batadv_softif_free+0x15/0x20 net/batman-adv/soft-interface.c:984 netdev_run_todo+0x6bf/0x1100 net/core/dev.c:10395 default_device_exit_batch+0x456/0x5b0 net/core/dev.c:11395 ops_exit_list+0x125/0x170 net/core/net_namespace.c:175 cleanup_net+0x4ee/0xb10 net/core/net_namespace.c:614 process_one_work+0x99a/0x15e0 kernel/workqueue.c:2405 worker_thread+0x67d/0x10c0 kernel/workqueue.c:2552 kthread+0x344/0x440 kernel/kthread.c:379 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 </TASK> --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. If the bug is already fixed, let syzbot know by replying with: #syz fix: exact-commit-title If you want to change bug's subsystems, reply with: #syz set subsystems: new-subsystem (See the list of subsystem names on the web dashboard) If the bug is a duplicate of another bug, reply with: #syz dup: exact-subject-of-another-report If you want to undo deduplication, reply with: #syz undup

1 0

Re: [PATCH 1/1] batman-adv: Broken sync while rescheduling delayed work
by Jakub Kicinski 08 Jun '23

08 Jun '23

On Wed, 7 Jun 2023 17:55:15 +0200 Simon Wunderlich wrote: > The reason for these issues is the lack of synchronization. Delayed > work (batadv_dat_purge) schedules new timer/work while the device > is being deleted. As the result new timer/delayed work is set after > cancel_delayed_work_sync() was called. So after the device is freed > the timer list contains pointer to already freed memory. I guess this is better than status quo but is the fix really complete? We're still not preventing the timer / work from getting scheduled and staying alive after the netdev has been freed, right?

5 4

Re: [PATCH 1/1] batman-adv: Broken sync while rescheduling delayed work
by patchwork-bot+netdevbpf＠kernel.org 08 Jun '23

08 Jun '23

Hello: This patch was applied to netdev/net.git (main) by Simon Wunderlich <sw(a)simonwunderlich.de>: On Wed, 7 Jun 2023 17:55:15 +0200 you wrote: > From: Vladislav Efanov <VEfanov(a)ispras.ru> > > Syzkaller got a lot of crashes like: > KASAN: use-after-free Write in *_timers* > > All of these crashes point to the same memory area: > > [...] Here is the summary with links: - [1/1] batman-adv: Broken sync while rescheduling delayed work https://git.kernel.org/netdev/net/c/abac3ac97fe8 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html

1 0

[PATCH 0/1] pull request for net: batman-adv 2023-06-07
by Simon Wunderlich 07 Jun '23

07 Jun '23

Hi David, hi Jakub, here is a bugfix for batman-adv which we would like to have integrated into net. Please pull or let me know of any problem! Thank you, Simon The following changes since commit 44c026a73be8038f03dbdeef028b642880cf1511: Linux 6.4-rc3 (2023-05-21 14:05:48 -0700) are available in the Git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-net-pullrequest-20230607 for you to fetch changes up to abac3ac97fe8734b620e7322a116450d7f90aa43: batman-adv: Broken sync while rescheduling delayed work (2023-05-26 23:14:49 +0200) ---------------------------------------------------------------- Here is a batman-adv bugfix: - fix a broken sync while rescheduling delayed work, by Vladislav Efanov ---------------------------------------------------------------- Vladislav Efanov (1): batman-adv: Broken sync while rescheduling delayed work net/batman-adv/distributed-arp-table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0

[syzbot] Monthly batman report (Jun 2023)
by syzbot 06 Jun '23

06 Jun '23

Hello batman maintainers/developers, This is a 31-day syzbot report for the batman subsystem. All related reports/information can be found at: https://syzkaller.appspot.com/upstream/s/batman During the period, 0 new issues were detected and 0 were fixed. In total, 9 issues are still open and 20 have been fixed so far. Some of the still happening issues: Ref Crashes Repro Title <1> 5426 Yes WARNING: ODEBUG bug in netdev_run_todo https://syzkaller.appspot.com/bug?extid=f9484b345f41843fc9a9 <2> 1375 Yes WARNING: ODEBUG bug in netdev_freemem (2) https://syzkaller.appspot.com/bug?extid=c4521ac872a4ccc3afec <3> 128 Yes INFO: rcu detected stall in batadv_nc_worker (3) https://syzkaller.appspot.com/bug?extid=69904c3b4a09e8fa2e1b --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. To disable reminders for individual bugs, reply with the following command: #syz set <Ref> no-reminders To change bug's subsystems, reply with: #syz set <Ref> subsystems: new-subsystem You may send multiple commands in a single email message.

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N