B.A.T.M.A.N

b.a.t.m.a.n@lists.open-mesh.org

15 participants
4308 discussions

[B.A.T.M.A.N.] throughput on wired interfaces?
by dan 15 Feb '17

15 Feb '17

Anyone know what the throughput capacity of batman-adv is? To be more specific, if I have gigabit ethernet interfaces in bat0 on a number of nodes, will batman-adv cause a significant drop in throughput when relaying traffic or cause a significant increase in latency? What about 10G?

1 0

[B.A.T.M.A.N.] how to hand ptp links and still access radio management interfaces
by dan 11 Feb '17

11 Feb '17

I'm trying to figure out the best way to handle this: (bat0-eth1) <===> PTP Radio1 ~~~~~~~ PTP Radio2 <===> (eth1-bat0) (eth1 is in bat0) These radios only have 1 interface (ie, no management interface) so I have to handle their configuration by assigning an IP to the same interface I want to connect into batman-adv. I considered: bat0-bridge-eth1 <===> PTP Radio1 ~~~~~~~ PTP Radio2 <===> eth1-bridge-bat0 but this means the link isn't in the mesh I don't know if this would work: bat0-bridge-eth1 <===> PTP Radio1 ~~~~~~~ PTP Radio2 <===> eth1-bridge-bat0 (bat0-eth1.10)~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~(bat0-eth1.10) because I don't know if the eth1.10 vlan will be touched by the bridge, or if it will work with bat0 this way. The purpose here is to use higher end radios like a ubiquiti airfiber 5x to reduce hop-counts and increase capacity. Any thoughts?

3 6

[B.A.T.M.A.N.] [PATCH 0/6] batman-adv: broadcast packet aggregation
by Linus Lüssing 09 Feb '17

09 Feb '17

Hi, Here is a first patchset to reintroduce aggregation support for BATMAN V, too - as well as any other packet type with a broadcast destination. Branch: * https://git.open-mesh.org/batman-adv.git/shortlog/refs/heads/linus/aggregat… Regards, Linus PS: Requires: "batman-adv: Introduce packet type independent TVLV handler API" (40e5c9e798ec, available on patchwork or linus/aggregation branch) --- RFC->v1: * removed tvlv (un)pack ctx wrappers * fixed a crash when deaggregating ARP packets * now compile tested down to 3.2, too (no issues found) * now stress tested with multicast traffic of a larger, public mesh setup

2 8

[B.A.T.M.A.N.] bat0 trunk vlans?
by dan 09 Feb '17

09 Feb '17

Assuming MTU is great enough (1528 right? 1500+24 batman-adv+4 VLAN), can the bat0 interface act as trunk for VLANs? 2 Nodes: bat0: eth1 bridge0: eth0|bat0 device connected to node1-eth0 tags vlan20, does that traverse the bat0 mesh and come out node2-eth0 with tag in-tact? Does it traverse node1-eth0 at all? I have another post on how to manage PtP radios in-line a batman-adv link, wondering if I can configure them to a management VLAN bat0-eth0 native vlan bat1-eth0.10 <- radio interface vlan10 ... and if so, how does that effect the possibility of trunking VLANs across bat0. in theory, bat0 fully encapsulates packets entering node1-eth0 so the VLAN is invisible 'outside' batman-adv encapsulation so bat-eth0.10 should work, but I just don't know how batman-adv handles VLANs... thanks

4 3

[B.A.T.M.A.N.] [PATCH] batman-adv: decrease maximum fragment size
by Linus Lüssing 31 Jan '17

31 Jan '17

From: Matthias Schiffer <mschiffer(a)universe-factory.net> With this patch the maximum fragment size is reduced from 1400 to 1280 bytes. Fragmentation v2 correctly uses the smaller of 1400 and the interface MTU, thus generally supporting interfaces with an MTU < 1400 bytes, too. However, currently "Fragmentation v2" does not support re-fragmentation. Which means that once a packet is split into two packets of 1400 + x bytes for instance and the next hop provides an interface with an even smaller MTU of 1280 bytes, then the larger fragment is lost. A maximum fragment size of 1280 bytes is a safer option as this is the minimum MTU required by IPv6, making interfaces with an MTU < 1280 rather exotic. Regarding performance, this should have no negative impact on unicast traffic: Having some more bytes in the smaller and some less in the larger does not change the sum of both fragments. Concerning TT, choosing 1280 bytes fragments might result in more TT messages than necessary when a large network is bridged into batman-adv. However, the TT overhead in general is marginal due to its reactive nature, therefore such a performance impact on TT should not be noticeable for a user. Cc: Matthias Schiffer <mschiffer(a)universe-factory.net> [linus.luessing(a)c0d3.blue: Added commit message] Signed-off-by: Linus Lüssing <linus.luessing(a)c0d3.blue> --- This patch is currently used in Gluon [1] because we stumbled over this issue in setups where batman-adv first fragmented to 1400 bytes for a wired, 1500B MTU connection and the larger fragment then being lost on the next hop's VPN interface with an MTU of 1280 bytes. [1]: https://github.com/freifunk-gluon/gluon/tree/master/patches/packages/routing net/batman-adv/main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index 57a8103..81c6a38 100644 --- a/net/batman-adv/main.h +++ b/net/batman-adv/main.h @@ -168,7 +168,7 @@ enum batadv_uev_type { /* Maximum number of fragments for one packet */ #define BATADV_FRAG_MAX_FRAGMENTS 16 /* Maxumim size of each fragment */ -#define BATADV_FRAG_MAX_FRAG_SIZE 1400 +#define BATADV_FRAG_MAX_FRAG_SIZE 1280 /* Time to keep fragments while waiting for rest of the fragments */ #define BATADV_FRAG_TIMEOUT 10000 -- 2.1.4

2 2

[B.A.T.M.A.N.] [PATCH 0/2] pull request for net-next: batman-adv 2017-01-28
by Simon Wunderlich 30 Jan '17

30 Jan '17

Hi David, here is another pull request for batman-adv in net-next. One of them fixes a regression introduced by a patch in the previous pull request two days ago. Please pull or let me know of any problem! Thank you, Simon The following changes since commit c33705188c493b7de3b8dc2956d67de91b444727: batman-adv: Treat NET_XMIT_CN as transmit successfully (2017-01-26 08:41:18 +0100) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-next-for-davem-20170128 for you to fetch changes up to 3e7514afc7d728dd47c5fe9d7a1f5216fe659cda: batman-adv: Fix includes for IS_ERR/ERR_PTR (2017-01-28 10:40:35 +0100) ---------------------------------------------------------------- Here are two fixes for batman-adv for net-next: - fix double call of dev_queue_xmit(), caused by the recent introduction of net_xmit_eval(), by Sven Eckelmann - Fix includes for IS_ERR/ERR_PTR, by Sven Eckelmann ---------------------------------------------------------------- Sven Eckelmann (2): batman-adv: Fix double call of dev_queue_xmit batman-adv: Fix includes for IS_ERR/ERR_PTR net/batman-adv/debugfs.c | 2 +- net/batman-adv/send.c | 4 +++- net/batman-adv/tp_meter.c | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-)

3 4

[B.A.T.M.A.N.] [PATCH] alfred: Avoid buffer overflow while querying ARP cache
by Sven Eckelmann 30 Jan '17

30 Jan '17

The arpreq.arp_dev is a limited buffer (16 bytes). Avoid that more bytes from the interface name are copied into this buffer by switching from strcpy to strncpy. Fixes: c7da798113a2 ("alfred: IPv4 multicast distribution support.") Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util.c b/util.c index 84ab3af..ed83895 100644 --- a/util.c +++ b/util.c @@ -92,7 +92,9 @@ int ipv4_arp_request(struct interface *interface, const alfred_addr *addr, sin->sin_family = AF_INET; sin->sin_addr.s_addr = addr->ipv4.s_addr; - strcpy(arpreq.arp_dev, interface->interface); + strncpy(arpreq.arp_dev, interface->interface, sizeof(arpreq.arp_dev)); + arpreq.arp_dev[sizeof(arpreq.arp_dev) - 1] = '\0'; + if (ioctl(interface->netsock, SIOCGARP, &arpreq) < 0) return -1; -- 2.11.0

3 3

[B.A.T.M.A.N.] [RFC PATCH 0/6] batman-adv: broadcast packet aggregation
by Linus Lüssing 29 Jan '17

29 Jan '17

Hi, Here is a first patchset to reintroduce aggregation support for BATMAN V, too. And while at it, for BATMAN VI, VII... etc, as well - in fact, it allows aggregating any batman packet with a broadcast destination ;). I am sending it as an RFC for now as compat code is still missing. And although it was tested in VMs, I still need to do some stress testing on some embedded routers. Regards, Linus PS: Requires: "batman-adv: Introduce packet type independent TVLV handler API" (1ddd189528fc, available on patchwork or linus/aggregation branch)

2 9

[B.A.T.M.A.N.] [PATCH v3 0/4] Broadcast Avoidances, Neighborhood Hash
by Linus Lüssing 29 Jan '17

29 Jan '17

Hi, Here's the second broadcast avoidance patchset. Hopefully, those two patchsets together should be an automatic approach and replacement for the (non-upstream) no-rebroadcast flag patch and the cases it is currently used for. Documentation: * https://www.open-mesh.org/projects/batman-adv/wiki/Broadcast-Avoidances Branch: * https://git.open-mesh.org/batman-adv.git/shortlog/refs/heads/linus/neighhash Regards, Linus ----- Known limitations: Avoidance potential is not fully detected in a setup with a mix of 100MBit/s and 1000MBit/s capable, wired nodes. If rebroadcast avoidance is strictly needed in such mixed, wired setups, too, then people could consider setting the throughput_override option of BATMAN V.

2 5

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Fix double call of dev_queue_xmit
by Sven Eckelmann 28 Jan '17

28 Jan '17

The net_xmit_eval has side effects because it is not making sure that e isn't evaluated twice. #define net_xmit_eval(e) ((e) == NET_XMIT_CN ? 0 : (e)) The code proposed by David Miller return net_xmit_eval(dev_queue_xmit(skb)); will therefore get transformed into return ((dev_queue_xmit(skb)) == NET_XMIT_CN ? 0 : (dev_queue_xmit(skb))) dev_queue_xmit will therefore be tried again (with an already consumed skb) whenever the return code is not NET_XMIT_CN. Fixes: 17efab9867c5 ("batman-adv: Simplify handling of NET_XMIT_CN") Signed-off-by: Sven Eckelmann <sven(a)narfation.org> --- net/batman-adv/send.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/batman-adv/send.c b/net/batman-adv/send.c index d9b28890..1489ec27 100644 --- a/net/batman-adv/send.c +++ b/net/batman-adv/send.c @@ -77,6 +77,7 @@ int batadv_send_skb_packet(struct sk_buff *skb, { struct batadv_priv *bat_priv; struct ethhdr *ethhdr; + int ret; bat_priv = netdev_priv(hard_iface->soft_iface); @@ -115,7 +116,8 @@ int batadv_send_skb_packet(struct sk_buff *skb, * congestion and traffic shaping, it drops and returns NET_XMIT_DROP * (which is > 0). This will not be treated as an error. */ - return net_xmit_eval(dev_queue_xmit(skb)); + ret = dev_queue_xmit(skb); + return net_xmit_eval(ret); send_skb_err: kfree_skb(skb); return NET_XMIT_DROP; -- 2.11.0

2 4

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

B.A.T.M.A.N